?
avatar PhilETaylor
PhilETaylor
26 Jan 2016

screen shot 2016-01-26 at 05 19 10
I propose a change where the BATCH and the DELETE button are moved apart.

In order to run a BATCH process you need to select a lot of "things" (say users in user manager) and then you move your mouse up to the BATCH button to run a batch process (like force password reset) - however it is also very very very very (note very) easy to click the delete button by mistake and thus all the entries that you have selected for batch process (lets say, 1000 users) are now deleted with no further "are you sure!?" messages - they are gone.. zip nada... gone... and then you have to waste an hour reinstalling from backup... if you had a backup... feel my pain here????

So a simple change that can ensure that quick clicking mistakes are avoided....

avatar PhilETaylor PhilETaylor - open - 26 Jan 2016
avatar Bakual
Bakual - comment - 26 Jan 2016

We could also add a "Are you sure" message to the delete button in the user manager. I think the user manager is the only place where you directly can delete items. Other components have a "trash" state, you can't directly delete items from published state in those.

avatar Fedik
Fedik - comment - 26 Jan 2016

:+1: for confirmation message here

avatar infograf768
infograf768 - comment - 26 Jan 2016

Direct Delete is also present for Templates styles, Overrides and Media

** Also Menus

avatar PhilETaylor
PhilETaylor - comment - 26 Jan 2016

I prefer not to be asked "are you sure" - just distance the batch from the delete butttons by rearranging the order :) a quick fix with no additional JS to code/test :) Less chance of a slip and deleting 1000 users..

avatar infograf768
infograf768 - comment - 26 Jan 2016

We could just add a margin as this would work everywhere in core:

#toolbar-delete {
    margin: 0 20px 0 20px;
}

would give

screen shot 2016-01-26 at 10 33 28

avatar Fedik
Fedik - comment - 26 Jan 2016

I think if action cannot be undone then the confirmation is required, as you can push that button accidentally, no matter you place it, ... especially if you work with the kids near you :wink:

avatar infograf768
infograf768 - comment - 26 Jan 2016

or cats... ;)

avatar Bakual
Bakual - comment - 26 Jan 2016

Afaik, the confirmation is already an option present for the delete button. You just need to activate it.

I wouldn't move the buttons, or you would have to move it in all places to be consistent.

avatar ssnobben
ssnobben - comment - 26 Jan 2016

Could I also mention something else that is very scary and that is.

Extension -- Manage --Manage left column and

Let say you have many modules and you filter all and then you want to Refresh Cache then but by mistake instead press Uninstall. Here better to move Uninstall away from Refresh Cache..

avatar infograf768
infograf768 - comment - 27 Jan 2016

Now preparing a patch implementing an alert for all delete cases (Delete and Empty Trash buttons) and Uninstall.

avatar infograf768
infograf768 - comment - 27 Jan 2016

See #8995
Thank you for testing

avatar Bakual
Bakual - comment - 27 Jan 2016

Closing as we have a PR.

avatar Bakual Bakual - change - 27 Jan 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-01-27 13:46:49
Closed_By Bakual
avatar Bakual Bakual - close - 27 Jan 2016

Add a Comment

Login with GitHub to post a comment