see line 14:

<div class="tagspopular<?php echo $moduleclass_sfx; ?>">

I don't understand why ul should get same classes. Just makes it mor complicated in CSS.

Instead use something like

div.tagspopular ul{
 ....
}

Or use a template override for default.php

@basd82 is correct from a consistency perspective - if you check the other modules that produce lists then they work the way he expects

In all other modules it’s done this way (as far as I think the correct way), but in mod_tags_popular and mod_tags_similar not.

So I suggest keep to the standard.

Van: bertmert [mailto:notifications@github.com]
Verzonden: woensdag 20 januari 2016 11:43
Aan: joomla/joomla-cms joomla-cms@noreply.github.com
CC: Bas van den Dikkenberg bas@Dikkenberg.net
Onderwerp: Re: [joomla-cms] class is missing in the ul tags (#8945)

Or use a template override for default.php

—
Reply to this email directly or view it on GitHub#8945 (comment).

If you do this way, you can easily change the layout of a singel module

I can live with this change but have to fix 2 sites (not a problem).

If you do this way, you can easily change the layout of a singel module

I think It's easier to change if you have 1 surrounding div with this class ;-)

I think the surrounding div should also be removed then.
Why: Use a layout style html5 with your module change and you'll see that we have now 3 times the same $moduleclass_sfx and 2 times "tagspopular". One for div, one for ul. You have to force CSS with very "hard" rules. Leading div, ul and so on.

is correct from a consistency perspective

Yes.

@brieteeman I would like to work on this.

@flash1452 you dont need anyones permission

Closed as we have a PR for testing #9388