Joomla! Issue Tracker | Joomla! CMS #8941

Closed
7 Nov 2016
Medium
Build: staging
# 8941
Diff
shur:patch-3

Success

Success continuous-integration/travis-ci/pr The Travis CI build passed Details

User tests: Successful: Unsuccessful:

shur
20 Jan 2016

This PR just add deprecated note for unnecessary catslug parameter because it's not used anywhere.

af90499 20 Jan 2016

Delete unnecesary catslug from mod_articles_category

shur - open - 20 Jan 2016

shur - change - 20 Jan 2016

Status

New

⇒

Pending

joomla-cms-bot - change - 20 Jan 2016

Labels

Added: ?

ce90f1e 22 Jan 2016

catslug depricated note

shur - change - 22 Jan 2016

Title

…

De~~lete unnecesary catslug from~~ mod_articles_category

Depricated catslug note - mod_articles_category

anibalsanchez - test_item - 5 Feb 2016 - Tested unsuccessfully

anibalsanchez - comment - 5 Feb 2016

I have tested this item unsuccessfully on ce90f1e

The comment has a typo

If we are going to introduce these notices it should be standarized. For example:

// Legacy support to be removed in 4.0.

JLog::add('... is deprecated. Function will be removed in 4.0', JLog::WARNING, 'deprecated');

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8941.}

0a1e1d0 5 Feb 2016

Update helper.php

joomla-cms-bot - comment - 5 Feb 2016

This PR has received new commits.

CC: @anibalsanchez

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8941.}

shur - comment - 5 Feb 2016

I tried to look for other similar notices, in order to understand what is standardization here.
And I did not see any of the standard in these notices, except probably this notices must contain the word "deprecated".
So what notice I should insert here???

brianteeman - change - 1 Mar 2016

Category

⇒

Router / SEF

brianteeman - comment - 14 Apr 2016

I asked @wilsonge and he said to use the PHPDocumentor standard https://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_tags.deprecated.pkg.html so something like
/** @deprecated Some information here VERSION_TO_BE_REMOVED **/

BUT before that - what is the source that says that it is actually deprecated

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8941.}

shur - comment - 14 Apr 2016

There is no need to use catslug in Joomla 3.x because process link function - ContentHelperRoute::getArticleRoute - requires only catid (integer value).
/components/com_content/helpers/route.php
public static function getArticleRoute($id, $catid = 0, $language = 0)
https://github.com/joomla/joomla-cms/blob/staging/components/com_content/helpers/route.php#L32

Already discussed here #4363

#4363 (comment)
@Bakual : If you want to make it perfect, you can add a deprecated notice somewhere.

what I did

f58359d 14 Apr 2016

notice standardization

joomla-cms-bot - comment - 14 Apr 2016

This PR has received new commits.

CC: @anibalsanchez

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8941.}

brianteeman - comment - 14 Apr 2016

@shur There is no need to have multiple Pull Requests. I am assuming thats because you are using github.com
To apply the change here to the other places just go to your fork and select this branch (patch-3)
Or this direct link https://github.com/shur/joomla-cms/tree/patch-3

And then any edits you make there will be automatically added to this PR. No need to have multiple pull requests for this one issue. I am closing the others and pasting this message there as well

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8941.}

d00c9f8 14 Apr 2016

Depricated catslug note - mod_articles_latest

joomla-cms-bot - comment - 14 Apr 2016

This PR has received new commits.

CC: @anibalsanchez

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8941.}

486e699 14 Apr 2016

Depricated catslug note - mod_articles_news

joomla-cms-bot - comment - 14 Apr 2016

This PR has received new commits.

CC: @anibalsanchez