Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#8925] - Remove JLayoutFile deprecated methods from inside JLayoutFile class

? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
17 Jan 2016

Description

This PR removes the usage of deprecated methods inside jlayout file class.
This was generating a lot of deprecated warnings on the log console.

Followed deprecated warning instructions:

  • refreshIncludePaths() replaced by clearIncludePaths()
  • setLayout(arg) replaced by setLayoutId(arg)

#8935, #8925 and #8932 removes most of deprecated log messages in Joomla core.

How to test.

Check code diff.

avatar andrepereiradasilva andrepereiradasilva - open - 17 Jan 2016
avatar andrepereiradasilva andrepereiradasilva - change - 17 Jan 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jan 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 17 Jan 2016
Title
…
Remove JLayoutFile deprecated methos from inside JLayoutFile class
Remove JLayoutFile deprecated methods from inside JLayoutFile class
avatar brianteeman brianteeman - change - 20 Jan 2016
Category ⇒ Code style
avatar anibalsanchez anibalsanchez - test_item - 5 Feb 2016 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 5 Feb 2016

I have tested this item :white_check_mark: successfully on e1a09db

Test OK

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8925.

avatar SharkyKZ SharkyKZ - test_item - 10 Mar 2016 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 10 Mar 2016

I have tested this item :white_check_mark: successfully on e1a09db

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8925.

avatar brianteeman brianteeman - change - 10 Mar 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 10 Mar 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8925.

avatar joomla-cms-bot joomla-cms-bot - change - 10 Mar 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 12 Apr 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-04-12 22:57:37
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 12 Apr 2016
avatar wilsonge wilsonge - merge - 12 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 12 Apr 2016
avatar wilsonge wilsonge - reference | e7cf48a - 12 Apr 16
avatar wilsonge wilsonge - merge - 12 Apr 2016
avatar wilsonge wilsonge - close - 12 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2016
Labels Removed: ?
avatar wilsonge wilsonge - change - 12 Apr 2016
Milestone Added:
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 12 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar wilsonge
wilsonge - comment - 12 Jul 2016

OK So I think we made a mistake here. I just realised (painfully) that if you are overriding refreshIncludePaths to include your own custom paths like I was in one of my modules to set a custom path then suddenly nothing gets loaded. which is a bit of an issue :P that kinda break is a joomla 4 style thing. not sure what the solution is :/

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Jul 2016

revert?

avatar C-Lodder
C-Lodder - comment - 12 Jul 2016

#11084

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Jul 2016

@wilsonge do we revert this PR?

avatar mbabker
mbabker - comment - 12 Jul 2016

Yes.

Add a Comment

Login with GitHub to post a comment