? Success

User tests: Successful: Unsuccessful:

avatar roland-d
roland-d
16 Jan 2016

The docblocks were inconsistent nor following the code. This pull request fixes the docblocks to match the code.

There are no testing instructions as only the docblocks have been changed.

avatar roland-d roland-d - open - 16 Jan 2016
avatar roland-d roland-d - change - 16 Jan 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2016
Labels Added: ?
avatar infograf768 infograf768 - test_item - 16 Jan 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 16 Jan 2016

I have tested this item :white_check_mark: successfully on cdf9b06

Can be merged on review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8911.

avatar chrisdavenport
chrisdavenport - comment - 16 Jan 2016

That's not grammatically correct. Better would be "Array of properties available for use inside the layout file to build the displayed output".

avatar brianteeman
brianteeman - comment - 16 Jan 2016

Agree with Chris. Its as important that Doc blocks are easy to understand
as it is that the code is correct.
On 16 Jan 2016 9:48 am, "Chris Davenport" notifications@github.com wrote:

That's not grammatically correct. Better would be "Array of properties
available for use inside the layout file to build the displayed output".


Reply to this email directly or view it on GitHub
#8911 (comment).

avatar joomla-cms-bot
joomla-cms-bot - comment - 16 Jan 2016

This PR has received new commits.

CC: @infograf768


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8911.

avatar roland-d
roland-d - comment - 16 Jan 2016

Thanks, replaced the description with the suggestion by @chrisdavenport

avatar brianteeman brianteeman - test_item - 16 Jan 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 16 Jan 2016

I have tested this item :white_check_mark: successfully on b8bc176


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8911.

avatar brianteeman brianteeman - change - 16 Jan 2016
Category Code style Documentation
avatar infograf768 infograf768 - test_item - 16 Jan 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 16 Jan 2016

I have tested this item :white_check_mark: successfully on b8bc176


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8911.

avatar infograf768 infograf768 - change - 16 Jan 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 16 Jan 2016

RTC. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8911.

avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 16 Jan 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-01-16 23:06:13
Closed_By wilsonge
avatar wilsonge wilsonge - close - 16 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - close - 16 Jan 2016
avatar wilsonge wilsonge - reference | 75f8c99 - 16 Jan 16
avatar wilsonge wilsonge - merge - 16 Jan 2016
avatar wilsonge wilsonge - close - 16 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2016
Labels Removed: ?
avatar wilsonge wilsonge - change - 16 Jan 2016
Milestone Added:

Add a Comment

Login with GitHub to post a comment