[#8909] - Add the size param to Recaptcha plugin
- Closed
- 26 Jan 2016
- Medium
- Build: staging
- # 8909
- Diff
- LeGfrey:staging
- Pending Human Test Results: 1 Successful 1 Failed. Details
User tests: Successful: Unsuccessful:
Description
This PR enable users to set a size to the Recaptcha 2.0 plugin (compact or normal).
As you can see on the google documentation : https://developers.google.com/recaptcha/docs/display
Example
- Before (the field was in normal size):
- After (the field can be in compact size):
Test
You can test each mode by changing the configuration of the plugin :
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
@andrepereiradasilva Sure, thanks 
Looks like I'm kind of tired today 
2d62d7c
I have tested this item 
successfully on 2d62d7c
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8909.
This PR has received new commits.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8909.
Just added it. Thank you @brianteeman !
I have tested this item successfully on baf5962
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8909.
I have tested this item 
unsuccessfully on baf5962
Works perfectly with Captcha 2.0
But its not implemented for Captcha 1.0
As we currently support both it would be great if it could be applied to Captcha 1.0 as well
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8909.
@brianteeman it have no sense, and it not supported by Captcha 1 https://developers.google.com/recaptcha/old/docs/customization
Ok no problem then - all good
On 21 January 2016 at 13:18, Fedir Zinchuk notifications@github.com wrote:
@brianteeman https://github.com/brianteeman it have no sense, and it
not supported by Captcha 1
https://developers.google.com/recaptcha/old/docs/customization—
Reply to this email directly or view it on GitHub
#8909 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
Updated my test result based on comment and marked RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8909.
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-26 23:43:36 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
Thanks @andrepereiradasilva !
I made a mistake checking the IF statement.
My bad
Corrected in 06c4d4b