? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
13 Jan 2016

Description

This PR adds some visual and informative improvements to the Joomla Debug Console.

Before PR (Database Queries -> "Call stack" slider)

before-callstack

After PR (Database Queries -> "Call stack" slider)

after-callstack

Before PR (Log Messages)

before-logmessages

After PR (Log Messages)

after-logmessages

How to test

  1. Apply this patch.
  2. Turn on the debug in global config and enable the debug system plugin.
  3. Test any page in frontend or administrator and check the "Joomla Debug Console" in the bottom of the page.
  4. Verify the info and visual of "Database Queries" -> "Call stack" slider
  5. Verify the info and visual of "Log Messages"

Observations

Suggestions and improvements are welcome.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar andrepereiradasilva andrepereiradasilva - open - 13 Jan 2016
avatar andrepereiradasilva andrepereiradasilva - change - 13 Jan 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Jan 2016
Labels Added: ? ?
8eea871 13 Jan 2016 avatar andrepereiradasilva cs
avatar photodude
photodude - comment - 14 Jan 2016

:+1: I'll see if I can test this soon.

avatar photodude
photodude - comment - 15 Jan 2016

Would be nice if the "visual and informative improvements" also applied to the debug session info

avatar photodude photodude - test_item - 15 Jan 2016 - Tested successfully
avatar photodude
photodude - comment - 15 Jan 2016

I have tested this item :white_check_mark: successfully on 7fcc15a

Definitely a valuable improvement.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Jan 2016

@photodude

Would be nice if the "visual and informative improvements" also applied to the debug session info

I can change it to pretty-print the session json values (in PHP 5.4+)? ok for you? or are you referring to something else?

avatar watchfulli-dev
watchfulli-dev - comment - 15 Jan 2016

@test success, applied the patch and indeed better layout now


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Jan 2016
avatar watchfulli-dev watchfulli-dev - test_item - 15 Jan 2016 - Tested successfully
avatar watchfulli-dev
watchfulli-dev - comment - 15 Jan 2016

I have tested this item :white_check_mark: successfully on 7fcc15a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Jan 2016

@mbabker in this PR i did some changes in JLogEntry class so it can save the debug backtrace.
I need to made a PR to the log framework repository too, right?

avatar mbabker
mbabker - comment - 15 Jan 2016

Don't bother. The Framework's Log library is deprecated and all but abandoned at this point. We typehint the PSR-3 logging interface in the Framework where packages support logging and the consensus at the time was Monolog is exponentially better so we weren't rewriting our code to support the interface.

avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Jan 2016

ok thanks.

avatar photodude
photodude - comment - 15 Jan 2016

@andrepereiradasilva Yes, something like pretty-print the session json values. Anything would likely look better than the raw JSON values.

avatar joomla-cms-bot
joomla-cms-bot - comment - 16 Jan 2016

This PR has received new commits.

CC: @photodude, @watchfulli-dev


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

avatar joomla-cms-bot
joomla-cms-bot - comment - 16 Jan 2016

This PR has received new commits.

CC: @photodude, @watchfulli-dev


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Jan 2016

Done, can you test the session part now?

avatar joomla-cms-bot
joomla-cms-bot - comment - 16 Jan 2016

This PR has received new commits.

CC: @photodude, @watchfulli-dev


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

avatar joomla-cms-bot
joomla-cms-bot - comment - 16 Jan 2016

This PR has received new commits.

CC: @photodude, @watchfulli-dev


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

avatar joomla-cms-bot
joomla-cms-bot - comment - 16 Jan 2016

This PR has received new commits.

CC: @photodude, @watchfulli-dev


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

avatar alikon
alikon - comment - 16 Jan 2016

ok session
ok call stack
ko Log messages
gives different result items

avatar joomla-cms-bot
joomla-cms-bot - comment - 16 Jan 2016

This PR has received new commits.

CC: @photodude, @watchfulli-dev


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Jan 2016

@alikon thanks for the testing
"ok Log messages" now?

avatar alikon
alikon - comment - 17 Jan 2016

if we can have a subtotal for each logged category messages (not only for deprecated) should be OK
test administration plugins system debug

avatar andrepereiradasilva
andrepereiradasilva - comment - 17 Jan 2016

Joomla core has a LOT of deprecated messages .... :worried:

What we can do is making tabs there for priority and with the totals
ex: CRITICAL xx || WARNING xx || INFO xx || DEBUG xx

or by category
ex: Deprecated xx || Databasequery xx || etc xx

I think the deprecated warning should stay alone.

avatar 810 810 - test_item - 17 Jan 2016 - Tested successfully
avatar 810
810 - comment - 17 Jan 2016

I have tested this item :white_check_mark: successfully on f224435


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

avatar photodude photodude - test_item - 17 Jan 2016 - Tested successfully
avatar photodude
photodude - comment - 17 Jan 2016

I have tested this item :white_check_mark: successfully on f224435

I do agree that we should have a summary subtotal for each logged category in the log section.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

avatar andrepereiradasilva
andrepereiradasilva - comment - 17 Jan 2016

Ok. i will try do that in other PR.
This one has already lot of changes and is RTC.

I will also make some other improvements in the new PR.

avatar dgt41 dgt41 - change - 17 Jan 2016
Status Pending Ready to Commit
avatar dgt41
dgt41 - comment - 17 Jan 2016

RTC then it is!

avatar joomla-cms-bot joomla-cms-bot - change - 17 Jan 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 26 Jan 2016
Milestone Added:
avatar wilsonge wilsonge - change - 26 Jan 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-01-26 23:34:41
Closed_By wilsonge
avatar wilsonge wilsonge - close - 26 Jan 2016
avatar wilsonge
wilsonge - comment - 26 Jan 2016

Merged - thanks @andrepereiradasilva

avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2016
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 27 Jan 2016

Add a Comment

Login with GitHub to post a comment