[#8897] - issue #8891 fixed typo s/$cachable/$cacheable
- Closed
- 4 Feb 2016
- Medium
- Build: staging
- # 8897
- Diff
- N6REJ:8891
- Failure The Travis CI build failed Details
User tests: Successful: Unsuccessful:
replaced all $cachable with $cacheable
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
Please make a PR for com_weblinks repository too.
https://github.com/joomla-extensions/weblinks/blob/master/src/components/com_weblinks/controller.php
ok, its fixed... gosh idky I always have so much trouble.
@andrepereiradasilva ok, done.
Cool. Thanks
Please maintainers, relaunch Travis.
@infograf768 Travis returns an error on PHP 5.6 due to problems with the CS.
it is doc blocks problem variables don't align
ups sorry it is the comment after the variable
Merged and ty.
Bear
On 1/14/2016 04:13, Wojciech Smoliński wrote:
@N6REJ https://github.com/N6REJ see N6REJ#1
N6REJ#1—
Reply to this email directly or view it on GitHub
#8897 (comment).
there MUST be 2 spaces after the longest variable name
@N6REJ See N6REJ#2 by @izharaazmi
done & ty.
Bear
On 1/15/2016 19:06, Wojciech Smoliński wrote:
@N6REJ https://github.com/N6REJ See N6REJ#2
N6REJ#2 by @izharaazmi
https://github.com/izharaazmi—
Reply to this email directly or view it on GitHub
#8897 (comment).
brianteeman
- | Category | ⇒ | Code style |
omg this is constantly screwed up.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-04 17:41:17 |
| Closed_By | ⇒ | N6REJ |
I appreciate that offer, I THINK i got it right.
Bear
On 2/4/2016 11:53, Wojciech Smoliński wrote:
@N6REJ https://github.com/N6REJ If you want I can prepare new
version of this PR—
Reply to this email directly or view it on GitHub
#8897 (comment).
@N6REJ delete nbproject and revert .gitignore change