? Success

User tests: Successful: Unsuccessful:

avatar alex-filat
alex-filat
13 Jan 2016

301 redirect has been lost during several changes, but it is more preferable status for redirection

avatar alex-filat alex-filat - open - 13 Jan 2016
avatar alex-filat alex-filat - change - 13 Jan 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Jan 2016
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 13 Jan 2016

The current redirect is a 303 See Other (See https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/application/cms.php#L971)

A 301 redirect is 301 Moved Permanently.

avatar alex-filat
alex-filat - comment - 13 Jan 2016

Right but for search engines better to use 301 redirect, that's what fixed

avatar andrepereiradasilva
andrepereiradasilva - comment - 13 Jan 2016

Yes, i know. But a 301 redirect is "Permanent".
The language plugin redirects on each page load to the default/selected language that can use different URLs, so IMHO the redirect shouldn't be permanent.

avatar alex-filat
alex-filat - comment - 13 Jan 2016

With 303 status we have duplicates in serach index, it is more seriouse problem. I see many pepople looking for solution how to fix it and do a lot of hard code fixed inside of core. This is the right place where it should be fixed. For more flexible solution we can add parameter "Redirect status".

Sample:
with 303 redirect google will store both URLs in index
domain-name.com/contact -> domain-name.com/en/contact
with 301 redirect only the last one

For other languges we have tag and site map.

avatar brianteeman brianteeman - change - 25 Jan 2016
Category Multilanguage Router / SEF
avatar Simonkloostra Simonkloostra - test_item - 15 Apr 2016 - Tested successfully
avatar Simonkloostra
Simonkloostra - comment - 15 Apr 2016

I have tested this item :white_check_mark: successfully on ae373fc

I have tested this issue succesfully:
Build a multilingual site with 2 languages, set to display including their language codes (NL and EN). When going to the default page (example.com), I am redirected to the default language (example.com/en).
Before the patch was applied this was done with a 303-redirect.
After applying the test, I got a 301-redirect.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8894.

avatar Simonkloostra
Simonkloostra - comment - 15 Apr 2016

And to add to my test: I agree that 301-redirects are the correct way to go for language redirects.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8894.

avatar mikeveeckmans mikeveeckmans - test_item - 15 Apr 2016 - Tested successfully
avatar mikeveeckmans
mikeveeckmans - comment - 15 Apr 2016

I have tested this item :white_check_mark: successfully on ae373fc

TEST OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8894.

avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Apr 2016

@infograf768 please check this.

avatar brianteeman
brianteeman - comment - 15 Apr 2016

Thanks for testing this and confirming that the pull request is functionally correct.

I am setting this to Needs Review so that the CMS maintainers can make a decision


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8894.

avatar brianteeman brianteeman - change - 15 Apr 2016
Status Pending Needs Review
avatar infograf768
infograf768 - comment - 16 Apr 2016

301 is correct for multilang. This was changed in 3.4.

avatar infograf768 infograf768 - test_item - 16 Apr 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 16 Apr 2016

I have tested this item :white_check_mark: successfully on ae373fc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8894.

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Apr 2016

ok then

avatar brianteeman
brianteeman - comment - 16 Apr 2016

Sorry thought I had :)

avatar brianteeman brianteeman - change - 16 Apr 2016
Status Needs Review Ready to Commit
avatar brianteeman
brianteeman - comment - 16 Apr 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8894.

avatar joomla-cms-bot joomla-cms-bot - change - 16 Apr 2016
Labels Added: ?
avatar rdeutz rdeutz - change - 16 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - change - 16 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-16 20:31:09
Closed_By rdeutz
avatar rdeutz rdeutz - close - 16 Apr 2016
avatar rdeutz rdeutz - merge - 16 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 16 Apr 2016
avatar rdeutz rdeutz - reference | c7a8101 - 16 Apr 16
avatar rdeutz rdeutz - merge - 16 Apr 2016
avatar rdeutz rdeutz - close - 16 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 16 Apr 2016
Labels Removed: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 23 Apr 2016

now the browser is caching the 301 redirects ... which means that if i change the default language the browser will not change it until the browser cache is cleared... isuppose that will happen to with search engines...

avatar andrepereiradasilva
andrepereiradasilva - comment - 23 Apr 2016

i still think making this redirect a 301 (that by default caches the redirect in the browser) is a choice that has problems.

Although it seems we can have 301 without caching. See http://stackoverflow.com/questions/12192590/how-to-do-a-non-cached-301-redirect/19003320#19003320

@infograf768 please reavaluate this.

avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment