[#8891] - Typo
- Closed
- 13 Jan 2016
- Medium
- Build: master
- # 8891
Hi all.
I found a little typo in argument name of JControllerLegacy::display($cachable = false, $urlparams = array());
I think it should be "$cacheable"...
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-13 12:57:44 |
| Closed_By | ⇒ | roland-d |
brianteeman
- 
If it were a class var or a parameter value (like that fix_adress thing in JSession), then leaving it alone would have to be the case because it's part of the API. Internal method variables like that one, just fix them. Ya, there's no benefit, but if someone wants to fix it what's the big deal?
ok, hopefully I did it right this time.
done, just waiting for confirmation and testing.
Bear
On 1/13/2016 09:29, RolandD wrote:
@N6REJ https://github.com/N6REJ No need to re-open this, as your PR
will be leading once you submit it.—
Reply to this email directly or view it on GitHub
#8891 (comment).
| Labels |
Added:
?
|
||
@adamasantares This is not really a typo because the variable name is named as such everywhere in the code. It may be a typo in the English spelling but not something that will be changed in the code as it has no real benefit. Thank you for your contribution.