Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
24 Mar 2013

Joomla should not be recommending using "admin" as the default admin username during installation. This is giving a known credential which is 50% of the credentials needed for a site and so should be user generated and no default should be recommended.

I did look at contributing a pull request for this, however as it impacts on the language string INSTL_ADMIN_USER_DESC I gave up as I dont have the ability to translate

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30380

Screen Shot 2013-03-24 at 21 20 14

avatar PhilETaylor PhilETaylor - open - 24 Mar 2013
avatar PhilETaylor
PhilETaylor - comment - 24 Mar 2013

Closes duplicate Issue #888

avatar PhilETaylor
PhilETaylor - comment - 24 Mar 2013

@mbabker ok here is the pull request with just the english strings.

avatar mbabker
mbabker - comment - 24 Mar 2013

Thanks, greatly appreciated. Since language freeze is in effect already for 3.1.0, the earliest this would get in is for 3.1.1, but it has my support.

avatar PhilETaylor
PhilETaylor - comment - 24 Mar 2013

If we did not change the language prompt but just remove the default in the text box would it be able to get into 3.1.0 ? ;-) That would be a start.

avatar mbabker
mbabker - comment - 24 Mar 2013

We could clear the default for at least 3.1.0 then fix the language string for 3.1.1, yes.

avatar PhilETaylor
PhilETaylor - comment - 24 Mar 2013

see #890 for the part pull for Joomla 3.1.0 then.

avatar brianteeman
brianteeman - comment - 25 Mar 2013

:100: This will remove the last of the possible known variables in a joomla installation now that db prefix and id are randomised

avatar elinw
elinw - comment - 25 Mar 2013

I'd remove the default completely rather than set it to "". No default and required would be the proper set up. The required will override the default anyway but it is cleaner and we don't want to imply that saving blank is acceptable.

avatar PhilETaylor
PhilETaylor - comment - 25 Mar 2013

amazed how much work/chat is involved in just removing 5 characters from an inputbox... ok will do my third pull request for this in a moment...

avatar PhilETaylor
PhilETaylor - comment - 25 Mar 2013

Closing this PR in favor of the changes going into #890 which do not include language changes...

avatar nicksavov
nicksavov - comment - 26 Mar 2013

btw, there's no need to close and open up pull requests for changes. If you update your branch, it will automatically update the pull request :)

Cheers

avatar PhilETaylor
PhilETaylor - comment - 26 Mar 2013

yeah I know that but I was going to keep this branch open so that I could use it again once the language freeze was lifted :)

avatar nicksavov
nicksavov - comment - 26 Mar 2013

Ah OK :)

Add a Comment

Login with GitHub to post a comment