? ? Pending

User tests: Successful: Unsuccessful:

avatar yannis79
yannis79
11 Jan 2016

Countries list with ISO 3166 alpha-3 codes as values

countrylist.zip

avatar yannis79 yannis79 - open - 11 Jan 2016
avatar yannis79 yannis79 - change - 11 Jan 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jan 2016
Labels Added: ?
avatar bertmert bertmert - test_item - 17 Jan 2016 - Tested unsuccessfully
avatar bertmert
bertmert - comment - 17 Jan 2016

I have tested this item :red_circle: unsuccessfully on 8a773ec

Applied patch in current 3.5.0beta staging.

Added field countrylist in
/administrator/components/com_content/models/forms/article.xml
inside block

<fields name="attribs" label="COM_CONTENT_ATTRIBS_FIELDSET_LABEL">
<field
name="country"
type="countrylist"
label="countrylist"
description="countrylist" />

Opened article > Tabulator Options.

I see the field but all language placeholders are untranslated (e.g. JCOUNTRY_ARUBA)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8879.

avatar Bakual
Bakual - comment - 17 Jan 2016

The language strings definitively need translations provided for en-GB.
ALso, is there a reason you use alpha-3 codes and not the alpha-2 ones? In Joomla we use two letter codes for our language-country codes (eg "en-GB"). I think we should follow that where possible.

avatar joomla-cms-bot
joomla-cms-bot - comment - 17 Jan 2016

This PR has received new commits.

CC: @bertmert


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8879.

avatar yannis79
yannis79 - comment - 17 Jan 2016

I changed
ISO 3166 alpha-3 codes
to
ISO 3166 alpha-2 codes

I will add translations in en-GB.ini

avatar yannis79 yannis79 - reference | f99cba1 - 17 Jan 16
avatar yannis79 yannis79 - reference | 3cce873 - 18 Jan 16
avatar brianteeman brianteeman - change - 21 Jan 2016
Labels Added: ?
avatar renekorss renekorss - test_item - 18 Feb 2016 - Tested successfully
avatar renekorss
renekorss - comment - 18 Feb 2016

I have tested this item :white_check_mark: successfully on 6f2883b

Since translations are in different branch, I still see JCOUNTRY_ARUBA etc. @yannis79 could you merge your patch-2 into patch-1?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8879.

avatar renekorss
renekorss - comment - 18 Feb 2016

Sorry, meant to choose unsucessfully, can I somehow change test result?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8879.

avatar brianteeman
brianteeman - comment - 18 Feb 2016

You cant but I can ;)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8879.

avatar brianteeman brianteeman - alter_testresult - 18 Feb 2016 - renekorss : Tested unsuccessfully
avatar yannis79
yannis79 - comment - 18 Feb 2016

@renekorss, I would merge them but I really don't know how!

avatar brianteeman brianteeman - change - 10 Mar 2016
Category Fields
avatar renekorss
renekorss - comment - 28 Mar 2016

@yannis79 What tool are you using? On command line it should look like this:

git checkout patch-1
git merge patch-2
git push
avatar brianteeman
brianteeman - comment - 8 May 2016

In the current state this is not ready. Please update the PR as above or if you have issues please ask. If not this will have to be closed in a few weeks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8879.

avatar brianteeman brianteeman - change - 8 May 2016
Status Pending Information Required
avatar brianteeman
brianteeman - comment - 7 Jun 2016

As stated above this cannot be merged at this time and as there has been no update I am closing it. If it is updated as requested it can always be reopened


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8879.

avatar brianteeman brianteeman - change - 7 Jun 2016
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2016-06-07 10:03:32
Closed_By brianteeman
avatar brianteeman brianteeman - close - 7 Jun 2016

Add a Comment

Login with GitHub to post a comment