[#8874] - Regression: Pressing enter/return on create menu takes you to create menus page
- Closed
- 17 Jan 2016
- Medium
- Build: staging
- # 8874
- Diff
- wojsmol:fixbuttons
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
fix for joomla#8839 and other modal buttons
Steps to reproduce the issue
Create a new menu item, fill in the required fields, press enter/return.
Expected result
Expected behaviour is save menu item (and return to menu in question). i.e. exactly the same as save & close.
Actual result
You arrive at the create menus page. The item does not get saved.
System information (as much as possible)
System Information
Setting ValuePHP Built On Linux mail.sfworksdev.co.uk 2.6.32-431.5.1.el6.x86_64 #1 SMP Wed Feb 12 00:41:43 UTC 2014 x86_64
Database Version 5.5.37
Database Collation utf8_general_ci
PHP Version 5.4.37
Web Server Apache
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 3.4.8 Stable [ Ember ] 24-December-2015 19:30 GMT
Joomla! Platform Version Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.106 Safari/537.36Additional comments
PR based on #8839 (comment)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
Typo=> typr instead of type:
- 'footer' => '<button class="btn" data-dismiss="modal" aria-hidden="true">'
+ 'footer' => '<button class="btn" typr="button" data-dismiss="modal" aria-hidden="true">'
. JText::_("JLIB_HTML_BEHAVIOR_CLOSE") . '</button>'
@infograf768 typo fixed 
I have tested this item 
successfully on dda3274
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8874.
| Title |
|
||||||
Changed title as this is a regression.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8874.
| Title |
|
||||||
Milestone should be 3.5.0. For me, RTC
I have tested this item successfully on dda3274
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8874.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8874.
| Labels |
Added:
?
|
||
wilsonge
- | Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-17 15:48:01 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
This one can be merged on review. Everything is OK here!