[#8869] - Mod languages performance improvements
- Closed
- 17 Jan 2016
- Medium
- Build: staging
- # 8869
- Diff
- andrepereiradasilva:mod_languages-improvements
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Description
Mod_languages (the module with the language flags), is one of the modules that can be in all pages that has slower performances (if 3 or more languages > 10ms).
So, this PR makes some code changes to get some small performance improvements.
No behaviour is changed.
Performance Tests
| Published Languages | Before PR | After PR |
|---|---|---|
| 1 | ~5.5 ms | ~3.7 ms |
| 2 | ~7.5 ms | ~4.0 ms |
| 3 | ~10 ms | ~4.2 ms |
| 4 | ~12 ms | ~4.4 ms |
| 5 | ~15 ms | ~5.3 ms |
Note: Tests were made with Joomla Debug Console in PHP 5.6 - no caching
How to test
- Fresh Joomla install with multilanguage (install 5 or more languages)
- Apply this patch.
- Verify all the flags in mod_languages are working fine
To check the performance improvements, turn on Joomla debugging and check the Application: afterRenderModule mod_languages (xxxxxx) execution time, before and after the PR
Observations
Suggestions, code reviews and improvements are welcome.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
thanks again
This works fine.
Could you also correct the remaining pre-existing CS?
;?> to ; ?>
Done.
I have tested this item 
successfully on 2b4938e
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8869.
I have tested this item successfully on 2b4938e
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8869.
| Status | Pending | ⇒ | Ready to Commit |
@joomla-bot
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-17 13:36:26 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
| Milestone |
Added: |
||
@andrepereiradasilva see andrepereiradasilva#1