Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#8854] - Search Tools (from JLayouts) implemented in com_checkin

? ? Pending

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
7 Jan 2016

Description

In move to normalize the search/filter/order/limit bar (aka searchtools) in all administrator list views, and as other PR's have made for other list component/views, this PR adds JLayouts searchtools to com_checkin only view (checkin) and replacing the old HTML code.

Also:

  • Some HTML code corrected (table blocks order)
  • Resolves bug in pagination when set to "All" (none appeared)
  • Other minor improvements
Isis template
Before patch

com_checkin_isis_before

After patch

com_checkin_isis_after

Hathor template
Before & after patch (no change)

com_checkin_hathor_after

How to test

  1. Edit some content and don't save or close so they are in not checked status
  2. Go to com_checkin ("System" -> "Global check-in").
  3. Apply the patch
  4. Go again to com_checkin ("System" -> "Global check-in").
  5. Test the Search Tools (Search field, ordering and limit).
  6. View hathor template too.

Observations

Suggestions and code revisions are welcome.

Tags

administrator, checkin, search tools, jlayouts, list views, normalization

avatar andrepereiradasilva andrepereiradasilva - open - 7 Jan 2016
avatar andrepereiradasilva andrepereiradasilva - change - 7 Jan 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jan 2016
Labels Added: ? ?
avatar NLRoosj NLRoosj - test_item - 10 Jan 2016 - Tested successfully
avatar NLRoosj
NLRoosj - comment - 10 Jan 2016

I have tested this item :white_check_mark: successfully on aabe76b

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8854.

avatar dgt41
dgt41 - comment - 17 Jan 2016

@andrepereiradasilva can you fix the conflicts here?

avatar joomla-cms-bot
joomla-cms-bot - comment - 17 Jan 2016

This PR has received new commits.

CC: @NLRoosj

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8854.

avatar andrepereiradasilva
andrepereiradasilva - comment - 17 Jan 2016

Done

avatar anibalsanchez anibalsanchez - test_item - 27 Jan 2016 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 27 Jan 2016

I have tested this item :white_check_mark: successfully on 68417aa

It works OK

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8854.

avatar brianteeman brianteeman - change - 27 Jan 2016
Status Pending ⇒ Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 27 Jan 2016

RTC - thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8854.

avatar joomla-cms-bot joomla-cms-bot - change - 27 Jan 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 19 Feb 2016
Milestone Added:
avatar wilsonge
wilsonge - comment - 19 Feb 2016

Merged - thanks!

avatar wilsonge wilsonge - change - 19 Feb 2016
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-02-19 01:31:47
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 19 Feb 2016
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 19 Feb 2016
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment