User tests: Successful: Unsuccessful:
Resolves filtering by tags in the frontend. resolve #5998
How to test
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Rel_Number | 0 | ⇒ | 5998 |
Relation Type | ⇒ | Pull Request for |
Category | ⇒ | Tags |
@justinherrin added to Global config as well. Thanks for the heads up! Found a little bug while doing that.
I have tested this item unsuccessfully on c26ed28
1. Label looks strange
If no tag selected changing filter field Display # results in a message "no items".
Same behavior if you had selected a tag, got hits, and set back field to "Select Tag"
This is what I did:
Installed Joomla! 3.5.0-beta staging 2016-01-17 with demo datas (testing).
Applied patch.
Opened menu item All Front End Views > Article Category List
Changed category to: Sample-Data Articels.
Tabulator Category > Subcategory Levels: ALL
Tabulator List Layout > Filter Fields > Tags
Saved.
Added tags to several articles by batch button
Went to Content > Articles > Options button
Tabulator Blog/Featured Layouts > Include Subcategories: ALL
Saved
Front End... and so on.
This PR has received new commits.
CC: @bertmert
I have tested this item unsuccessfully on c3b4f1a
Success for Protostar template.
But not for Beez3 template.
This PR has received new commits.
CC: @bertmert
This PR has received new commits.
CC: @bertmert
I have tested this item successfully on 143ba26
I have tested this item unsuccessfully on 143ba26
Both templates Beez3 and Protostar been tested.
The principle works, just not quite logical IMHO.
When you select a tag with result 'There are no articles in this category...' then you are not able to select a different tag. The selection bar disappears. Only when you select the menu item again.
Secondly could you add a search option in the tags list? Quite useful when you have a lot of tags.
When you select a tag with result 'There are no articles in this category...' then you are not able to select a different tag. The selection bar disappears. Only when you select the menu item again.
That's not a misbehavior related to this PR. Try with title filter and search for nonsense. Same behavior.
Agree for the search part. It's by design.
But, when the title filter stays, in cause of "there are no articles..." it is more sophisticated.
@genesisfan I could fix that in a separate PR. Likewise with searching for a specific tag, I guess we could add in Typeahead. But the idea was same behavior as the backend. Which this PR solves.
@genesisfan @bertmert how do you guys suggest we continue? As I said I'm more then happy to make the other alterations but I don't feel they are part of this PR.
how do you guys suggest we continue?
I'm just a "helping user" and have nothing to decide here but from my point of view you have 2 successful tests and @genesisfan should differentiate and test again
with this in mind:
the problem that filter fields disappear if no items found is as old as Joomla I think. Not a fault of this PR and MUST be fixed otherwise.
(And should be fixed in all Joomla core components with frontend list views together (consistency).)
The second part is an additional feature. All you need is a line
JHtml::_('formbehavior.chosen', 'select');
in a template override of list view if you want this feature
VoilĂ :
BUT: I've asked the question some time ago if Beez3 should get always "chosened" selects or if it's prefered that not. If yes it would be easy. Just add line above to a relevant core file. BUT: I never got an answer. Thus I wouldn't add this feature to this PR if it would be mine. Know what I mean? Sometimes smaller steps are the faster ones ;-)
EDIT: See:
#8919 (comment)
But Beez3 normally doesn't use "chosened selects". There it's a really strange behavior to have sometimes this or that style. I don't know a way to suppress already loaded formbehavior.chosen. ... Please advise! Should Beez3 use "chosened selects" ON ALL PAGES or not? Sometimes it's forced to use them sometimes not.
I have tested this item successfully on 143ba26
> the problem that filter fields disappear if no items found is as old as Joomla I think. Not a fault of this PR and MUST be fixed otherwise.
Agree @bertmert and therefore successfully tested.
It would be nice if this normal behavior of the filter disappears could be fixed in another PR.
Thanks for testing @genesisfan !
Looks great - RTC
Status | Pending | ⇒ | Ready to Commit |
@brianteeman looks like the bot won't tag it :-/
Edit: and then it instantly did :-)
Labels |
Added:
?
|
Hy danielsmink, thx for this, I working on a Project where I will us it.
Can anybody tell me if this it already in the 3.5.0-RC Version?
I could not find it there.
@stefanpolzer No its not it was only tagged rtc after the release of RC
Milestone |
Added: |
@danielsmink cloud you please check the merge conflicts, thanks
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-04 15:01:46 |
Closed_By | ⇒ | rdeutz |
Labels |
Removed:
?
|
Can you also add "Tags" option to the Global Configuration area? I'm looking at the Global Configuration > Articles > List Layouts tab > Filter Field