? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
3 Jan 2016

Description

This PR adds "Category:" text to contacts, banners and newsfeeds list views just like there is in articles list view.

Before patch:
image

After patch:
image

How to test

  1. Go to contacts, banners and newsfeeds list views and check that each item has only the category name below the item title.
  2. Apply the patch
  3. Go to contacts, banners and newsfeeds list views and check that each item has "Category: " plus the category name below the item title, like in the articles list view.
avatar andrepereiradasilva andrepereiradasilva - open - 3 Jan 2016
avatar andrepereiradasilva andrepereiradasilva - change - 3 Jan 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jan 2016
Labels Added: ?
avatar justinherrin justinherrin - test_item - 5 Jan 2016 - Tested successfully
avatar justinherrin
justinherrin - comment - 5 Jan 2016

I have tested this item :white_check_mark: successfully on 359d932

Now that all 3 changes are consistent, things look good to me.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8832.

avatar justinherrin
justinherrin - comment - 5 Jan 2016

Can you also add this to the Banners > Tracks view?

avatar andrepereiradasilva
andrepereiradasilva - comment - 5 Jan 2016

Oh. missed that one. good find.
Will add later on.

avatar joomla-cms-bot
joomla-cms-bot - comment - 5 Jan 2016

This PR has received new commits.

CC: @justinherrin


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8832.

avatar andrepereiradasilva
andrepereiradasilva - comment - 5 Jan 2016

I had it, but didn't have banner tracks too test.
Can you test?

avatar justinherrin justinherrin - test_item - 6 Jan 2016 - Tested successfully
avatar justinherrin
justinherrin - comment - 6 Jan 2016

I have tested this item :white_check_mark: successfully on d2f4117

Thanks for adding to Banner Tracks view too!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8832.

avatar waader waader - test_item - 6 Jan 2016 - Tested successfully
avatar waader
waader - comment - 6 Jan 2016

I have tested this item :white_check_mark: successfully on d2f4117

Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8832.

avatar brianteeman brianteeman - change - 6 Jan 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 6 Jan 2016

RTC - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8832.

avatar joomla-cms-bot joomla-cms-bot - change - 6 Jan 2016
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 6 Jan 2016

@justinherrin, @waader thanks for testing

avatar rdeutz rdeutz - change - 6 Jan 2016
Milestone Added:
avatar infograf768
infograf768 - comment - 7 Jan 2016

@rdeutz

I think we can safely merge this into 3.5.0.

avatar rdeutz
rdeutz - comment - 7 Jan 2016

Agree, but it isn't a bug fix and we are in beta stage and we merge only bug fixes

avatar wilsonge wilsonge - change - 17 Jan 2016
Milestone Added:
avatar wilsonge wilsonge - change - 17 Jan 2016
Milestone Removed:
avatar wilsonge wilsonge - reference | 194af20 - 17 Jan 16
avatar wilsonge wilsonge - close - 17 Jan 2016
avatar wilsonge
wilsonge - comment - 17 Jan 2016

Merged with 194af20

avatar wilsonge wilsonge - change - 17 Jan 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-01-17 14:28:14
Closed_By wilsonge
avatar wilsonge wilsonge - close - 17 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - close - 17 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jan 2016
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 17 Jan 2016

Add a Comment

Login with GitHub to post a comment