? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
3 Jan 2016

Description

This PR does some improvements to administrator main menu list:

  • corrects an html error (missing " between href and title)
  • correct spaces between table lines -> (p to div)
  • put counters items colors like in categories, banners, contacts components
  • code style: adds ; and spaces at the end of php code
  • some minor adjustments
Before patch:

image

After patch:

image

How to test

  1. Fresh Joomla install with multilanguage (several languages).
  2. Apply this patch
  3. Go to menus view
  4. Check if everything is ok.
avatar andrepereiradasilva andrepereiradasilva - open - 3 Jan 2016
avatar andrepereiradasilva andrepereiradasilva - change - 3 Jan 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jan 2016
Labels Added: ?
avatar justinherrin justinherrin - test_item - 4 Jan 2016 - Tested successfully
avatar justinherrin
justinherrin - comment - 4 Jan 2016

I have tested this item :white_check_mark: successfully on 3462ea2

Tested PR successfully. Things look okay.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8830.

avatar anibalsanchez anibalsanchez - test_item - 6 Jan 2016 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 6 Jan 2016

I have tested this item :white_check_mark: successfully on 3462ea2

Test OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8830.

avatar brianteeman brianteeman - change - 6 Jan 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 6 Jan 2016

RTC - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8830.

avatar joomla-cms-bot joomla-cms-bot - change - 6 Jan 2016
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 6 Jan 2016

@justinherrin, @anibalsanchez thanks for testing

avatar rdeutz rdeutz - change - 6 Jan 2016
Milestone Added:
avatar NLRoosj NLRoosj - test_item - 10 Jan 2016 - Tested successfully
avatar NLRoosj
NLRoosj - comment - 10 Jan 2016

I have tested this item :white_check_mark: successfully on 3462ea2


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8830.

avatar wilsonge wilsonge - change - 17 Jan 2016
Milestone Added:
avatar wilsonge wilsonge - change - 17 Jan 2016
Milestone Removed:
avatar andrepereiradasilva andrepereiradasilva - reference | 8ca2a4f - 17 Jan 16
avatar andrepereiradasilva andrepereiradasilva - close - 17 Jan 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 17 Jan 2016

@wilsonge i will close this PR since you merge it in 8ca2a4f

avatar andrepereiradasilva andrepereiradasilva - change - 17 Jan 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-01-17 14:56:31
Closed_By andrepereiradasilva
avatar andrepereiradasilva andrepereiradasilva - close - 17 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - close - 17 Jan 2016
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 17 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jan 2016
Labels Removed: ?
avatar wilsonge
wilsonge - comment - 17 Jan 2016

Thanks!

Add a Comment

Login with GitHub to post a comment