User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
I suggest to modify featured default_item.php to use the layout in order to correct the issue there too.
You need to go to issues.joomla.org and login with your github credentials. Open the PR and hit the test button. Put your comment in and mark it as a successful test.
In order to get implemented it needs two of those successful tests, I, as creator of the PR, am not allowed/do not count.
Will look into Featured later, thank you @infograf768 for reporting it.
@sovainfo thank yo for the info. I did exactly what you wrote above, step by step. I dont see a test button to hit. (I also searched the page, there is no test button that comes with the search results.) Then I searched github help about "how to test a pull request" or "mark a pull request as a successful test" I did not have any answers. I really would like to help you and want this feature to be published but I don't have that test button. Is it because of my credentials?
Indeed, point 7 tells you what to do. Please report again when there is no test button.
I have tested this item successfully on 002eae6
Everything fine.
I have tested this item successfully on 002eae6
I had to give authorization to repository or something to get this button. And it took one of my senior developer more than half an hour to understand how the button appears, really. Thank you very much for your help :-)
Suggest to use a separate PR for fixing this issue for Featured. Agree that Featured and Category Blog are out of sync. Probably requires more research to get them on the same page.
Don't think applying the change made to the title layout to default_item.php is the right thing to do. Agree with @infograf768 on the solution for Featured, not sure its the only thing out of sync.
Status | Pending | ⇒ | Ready to Commit |
Category | ⇒ | Layout |
This should be RTC - silly robots
Labels |
Added:
?
|
Milestone |
Added: |
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-03 09:36:03 |
Closed_By | ⇒ | rdeutz |
Labels |
Removed:
?
|
I have tested all the combinations (authorized links = yes/no, clickable title links = yes/no, and acess rights = registered) and it worked as expected.