? Success

User tests: Successful: Unsuccessful:

avatar sovainfo
sovainfo
3 Jan 2016

Fixing #8790

When using the teaser there should be a link if so configured.

avatar sovainfo sovainfo - open - 3 Jan 2016
avatar sovainfo sovainfo - change - 3 Jan 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jan 2016
Labels Added: ?
avatar hakanara
hakanara - comment - 3 Jan 2016

I have tested all the combinations (authorized links = yes/no, clickable title links = yes/no, and acess rights = registered) and it worked as expected.

avatar sovainfo
sovainfo - comment - 3 Jan 2016

@hakanara Please mark this as an successful test with issues.joomla.org.

avatar infograf768
infograf768 - comment - 4 Jan 2016

I suggest to modify featured default_item.php to use the layout in order to correct the issue there too.

avatar hakanara
hakanara - comment - 4 Jan 2016

@sovainfo please tell me how to do that. I don't know how to do it on this platform. I thought a simple OK message would be enough. Thank you very much for your time. I appreciate that very much.

avatar sovainfo
sovainfo - comment - 4 Jan 2016

You need to go to issues.joomla.org and login with your github credentials. Open the PR and hit the test button. Put your comment in and mark it as a successful test.
In order to get implemented it needs two of those successful tests, I, as creator of the PR, am not allowed/do not count.
Will look into Featured later, thank you @infograf768 for reporting it.

avatar hakanara
hakanara - comment - 4 Jan 2016

@sovainfo thank yo for the info. I did exactly what you wrote above, step by step. I dont see a test button to hit. (I also searched the page, there is no test button that comes with the search results.) Then I searched github help about "how to test a pull request" or "mark a pull request as a successful test" I did not have any answers. I really would like to help you and want this feature to be published but I don't have that test button. Is it because of my credentials?

avatar sovainfo
sovainfo - comment - 4 Jan 2016

Indeed, point 7 tells you what to do. Please report again when there is no test button.

avatar sakicnet sakicnet - test_item - 4 Jan 2016 - Tested successfully
avatar sakicnet
sakicnet - comment - 4 Jan 2016

I have tested this item :white_check_mark: successfully on 002eae6

Everything fine.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8827.

avatar hakanara hakanara - test_item - 4 Jan 2016 - Tested successfully
avatar hakanara
hakanara - comment - 4 Jan 2016

I have tested this item :white_check_mark: successfully on 002eae6


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8827.

avatar hakanara
hakanara - comment - 4 Jan 2016

I had to give authorization to repository or something to get this button. And it took one of my senior developer more than half an hour to understand how the button appears, really. Thank you very much for your help :-)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8827.

avatar sovainfo
sovainfo - comment - 4 Jan 2016

Suggest to use a separate PR for fixing this issue for Featured. Agree that Featured and Category Blog are out of sync. Probably requires more research to get them on the same page.
Don't think applying the change made to the title layout to default_item.php is the right thing to do. Agree with @infograf768 on the solution for Featured, not sure its the only thing out of sync.

avatar dgt41 dgt41 - change - 17 Jan 2016
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 13 Apr 2016
Category Layout
avatar brianteeman
brianteeman - comment - 3 May 2016

This should be RTC - silly robots


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8827.

avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 3 May 2016
Milestone Added:
avatar rdeutz rdeutz - close - 3 May 2016
avatar rdeutz rdeutz - merge - 3 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 3 May 2016
avatar rdeutz rdeutz - change - 3 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-03 09:36:03
Closed_By rdeutz
avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment