? Success
Pull Request for # 8765

User tests: Successful: Unsuccessful:

avatar photodude
photodude
31 Dec 2015

Copies the proper CLI bootstrap for the CMS from /joomla-cms/cli/finder_indexer.php
Addresses issues from #8765

Testing
1. add patch
https://docs.joomla.org/Testing_Joomla!_patches
2. Attempt to access the file by calling: your-joomla-domain.com/bin/keychain.php with any Browser
3. Observe the notice "This is a command line only application." ( step 3 completes testing for issues in #8765 )
4. Use the keychain through CLI, with no change in behavior see documentation

avatar photodude photodude - open - 31 Dec 2015
avatar photodude photodude - change - 31 Dec 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Dec 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 31 Dec 2015
Rel_Number 0 8765
Relation Type Pull Request for
avatar brianteeman brianteeman - change - 31 Dec 2015
Category CLI
avatar digitalgarage
digitalgarage - comment - 3 Feb 2016

I tested this and can confirm that after applying patch the notice about command line only application was displayed. Prior to applying patch the notice wasn't displayed.

I wasn't real sure on testing from the CLI so just created a new CLI script and created a new keychain object. There were no error messages displayed. Was there something specific that needed to be tested from the CLI?

Eric.

avatar anibalsanchez anibalsanchez - test_item - 3 Feb 2016 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 3 Feb 2016

I have tested this item :white_check_mark: successfully on 2f3403e

It works OK.

My test:

  • http://.../bin/keychain.php "This is a command line only application."
  • cd bin
  • openssl genrsa -des3 -out private.key 1024
  • php -f keychain.php init --passphrase=passphrase.file --private-key=private.key
  • Test OK
    This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8820.
avatar digitalgarage digitalgarage - test_item - 3 Feb 2016 - Tested successfully
avatar digitalgarage
digitalgarage - comment - 3 Feb 2016

I have tested this item :white_check_mark: successfully on 2f3403e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8820.

avatar brianteeman brianteeman - change - 3 Feb 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 3 Feb 2016

Thanks for testing - setting RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8820.

avatar joomla-cms-bot joomla-cms-bot - change - 3 Feb 2016
Labels Added: ?
avatar Kubik-Rubik Kubik-Rubik - change - 3 Feb 2016
Milestone Added:
avatar Kubik-Rubik
Kubik-Rubik - comment - 3 Feb 2016

Should be fixed asap. Thank you @photodude!

avatar Kubik-Rubik Kubik-Rubik - change - 3 Feb 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-02-03 10:23:30
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 3 Feb 2016
avatar joomla-cms-bot joomla-cms-bot - close - 3 Feb 2016
avatar Kubik-Rubik Kubik-Rubik - reference | f3479a9 - 3 Feb 16
avatar Kubik-Rubik Kubik-Rubik - merge - 3 Feb 2016
avatar Kubik-Rubik Kubik-Rubik - close - 3 Feb 2016
avatar joomla-cms-bot joomla-cms-bot - change - 3 Feb 2016
Labels Removed: ?
avatar photodude
photodude - comment - 3 Feb 2016

Thanks @anibalsanchez @digitalgarage for testing.
@Kubik-Rubik your welcome and thanks For the merge.

@mbabker Thanks for identifying the likely solution in the source issue.

avatar photodude photodude - head_ref_deleted - 3 Feb 2016

Add a Comment

Login with GitHub to post a comment