? Success

User tests: Successful: Unsuccessful:

avatar demis-palma
demis-palma
31 Dec 2015

Method call uses 2 parameters, but method signature uses 1 parameter

avatar demis-palma demis-palma - open - 31 Dec 2015
avatar demis-palma demis-palma - change - 31 Dec 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Dec 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 30 Mar 2016

Please provide some instructions for how someone can test this.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8818.

avatar brianteeman brianteeman - change - 30 Mar 2016
Category CLI
avatar brianteeman brianteeman - change - 30 Mar 2016
Status Pending Information Required
avatar zero-24 zero-24 - reference | d27d90c - 30 Mar 16
avatar zero-24
zero-24 - comment - 30 Mar 2016

@demis-palma @brianteeman this is a upstream issue with the keychain package. I have just opend a issue there so this here can be closed i think: joomla-framework/keychain#10

If they accept it and release a new version the fix get into the CMS

avatar mbabker mbabker - change - 30 Mar 2016
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2016-03-30 13:24:54
Closed_By mbabker
avatar mbabker mbabker - close - 30 Mar 2016
avatar mbabker mbabker - close - 30 Mar 2016
avatar mbabker mbabker - change - 30 Mar 2016
Status Closed New
Closed_Date 2016-03-30 13:24:54
Closed_By mbabker
avatar mbabker mbabker - change - 30 Mar 2016
Status New Pending
avatar mbabker mbabker - reopen - 30 Mar 2016
avatar mbabker mbabker - reopen - 30 Mar 2016
avatar mbabker
mbabker - comment - 30 Mar 2016

This needs to be merged here. The Framework Keychain package isn't used in the CMS.

avatar zero-24
zero-24 - comment - 30 Mar 2016

@roland-d @wilsonge @Bakual @Kubik-Rubik can you merge here or set RTC for 3.5.2? Keychain isnot used in the CMS and the framework fixed the upstream bug ;)

avatar brianteeman brianteeman - change - 30 Mar 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2016
Labels Removed: ?
avatar roland-d roland-d - change - 30 Mar 2016
Milestone Added:
avatar roland-d
roland-d - comment - 30 Mar 2016

I have set this to 3.5.2 unless @wilsonge wants to merge it, he can do so.

avatar brianteeman brianteeman - change - 30 Mar 2016
Status Pending Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2016
Milestone Removed:
avatar brianteeman
brianteeman - comment - 30 Mar 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8818.

avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 30 Mar 2016
Milestone Added:
avatar zero-24
zero-24 - comment - 30 Mar 2016

:+1: Thanks!

avatar wilsonge
wilsonge - comment - 30 Mar 2016

Yes 3.5.2 for this - but I agree it's correct on a quick review and has been wrong since it got introduced into the platform in September 2012 :P joomla/joomla-platform@56895f7

avatar rdeutz rdeutz - change - 12 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-12 19:11:29
Closed_By rdeutz
avatar rdeutz rdeutz - close - 12 Apr 2016
avatar rdeutz rdeutz - merge - 12 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 12 Apr 2016
avatar rdeutz rdeutz - reference | 042b2ca - 12 Apr 16
avatar rdeutz rdeutz - merge - 12 Apr 2016
avatar rdeutz rdeutz - close - 12 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2016
Labels Removed: ?
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment