? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
28 Dec 2015

This corrects #7094 (comment)
It also adds autocomplete off for the passwords fields in installation (site and database)

To test, same instructions as #7094
The password field is filled even when it is only optional thus forcing to enter a value in the Confirm Password field. As this is not expected by the user, the error "Invalid field: Confirm Password" displays.

To test:
3 instances:

  1. Edit a user (editing yourself as superuser) through User Manager.
  2. Editing your own profile in back-end
    3.Editing your own profile in front-end

In these 3 cases, you will see that the password field contains a value.

Patch and retest, then save any user parameter without touching at the passwords fields. Now should be OK.

This patch also
1.adds autocomplete off to the database password field when installing Joomla as it picks the Username field when not set such.
2. solves autocomplete off for Firefox for site passwords when installing Joomla

Note: to test, the password has to be saved first (Firefox message) in a former new installation.

@ggppdk @fontanil
Thank you for testing

avatar infograf768 infograf768 - open - 28 Dec 2015
avatar infograf768 infograf768 - change - 28 Dec 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Dec 2015
Labels Added: ?
avatar infograf768 infograf768 - change - 28 Dec 2015
Category Administration Installation
avatar infograf768 infograf768 - change - 28 Dec 2015
The description was changed
avatar fontanil fontanil - test_item - 28 Dec 2015 - Tested successfully
avatar fontanil
fontanil - comment - 28 Dec 2015

I have tested this item :white_check_mark: successfully on 974f930

Tested on 3.5.0 beta1: works correctly. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8800.

avatar infograf768
infograf768 - comment - 29 Dec 2015

We need another test
@colivier
@dgt41

avatar colivier
colivier - comment - 29 Dec 2015

I edited and changed some parameters of a user in the backend and I saved without the error "Invalid field: Confirm Password".

I cannot reproduce the issue.

Test on FF 43.0.2

avatar infograf768
infograf768 - comment - 29 Dec 2015

@colivier
As the issue happens for some users, can you confirm that the PR also works for you.
For the new stuff, i.e. when installing Joomla, this can be tested easily on your test site by changing temporarily the name of the installation folder to "_installation" and trying to reinstall. No need to go further than the database settings.

avatar anibalsanchez anibalsanchez - test_item - 2 Jan 2016 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 2 Jan 2016

I have tested this item :white_check_mark: successfully on 974f930

Test OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8800.

avatar infograf768 infograf768 - change - 3 Jan 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 3 Jan 2016

Thanks for testing. RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8800.

avatar joomla-cms-bot joomla-cms-bot - change - 3 Jan 2016
Labels Added: ?
avatar ggppdk
ggppdk - comment - 5 Jan 2016

@infograf768
thanks, i am sorry i could not make this PR as i promised, obligation, holidays
plus i need to setup my local staging environment again

avatar rdeutz rdeutz - change - 6 Jan 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-01-06 11:19:53
Closed_By rdeutz
avatar rdeutz rdeutz - close - 6 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - close - 6 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jan 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment