? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
27 Dec 2015

Description

This PR makes cosmetic changes to com_tags XML files to be in compliance with XML coding standards (Check https://joomla.github.io/coding-standards/?coding-standards/chapters/xml.md).

Only an extra change has been made: replaced desc="JGLOBAL_FIELD_CREATED_BY_DESC" for description="JGLOBAL_FIELD_CREATED_BY_DESC"

How to test

This is a cosmic change. A simple view of the changes should be enough.
But for test you can check if the tags component work as before.

Observations

Any improvements are welcome

avatar andrepereiradasilva andrepereiradasilva - open - 27 Dec 2015
avatar andrepereiradasilva andrepereiradasilva - change - 27 Dec 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Dec 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 27 Dec 2015

The code was much easier to read before. I dont see the benefit in this
change

On 27 December 2015 at 23:01, andrepereiradasilva notifications@github.com
wrote:

Description

This PR makes cosmetic changes to com_tags XML files to be in
compliance with XML coding standards (Check
https://joomla.github.io/coding-standards/?coding-standards/chapters/xml.md
).

Only an extra change has been made: replaced
desc="JGLOBAL_FIELD_CREATED_BY_DESC" for
description="JGLOBAL_FIELD_CREATED_BY_DESC"
How to test

This is a cosmic change. A simple view of the changes should be enough.
But for test you can check if the tags component work as before.
Observations

Any improvements are welcome

You can view, comment on, or merge this pull request online at:

#8798
Commit Summary

  • Merge remote-tracking branch 'refs/remotes/joomla/staging' into staging
  • Merge remote-tracking branch 'refs/remotes/joomla/staging' into staging
  • Merge remote-tracking branch 'refs/remotes/joomla/staging' into staging
  • Merge branch 'staging' of https://github.com/andrepereiradasilva/joomla-cms into staging
  • Merge remote-tracking branch 'refs/remotes/joomla/staging' into xml-com_tags
  • com_tags compliance with Joomla! XML coding standards

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#8798.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar andrepereiradasilva
andrepereiradasilva - comment - 27 Dec 2015

@brianteeman the change made has just try to follow the Joomla! standard in
https://joomla.github.io/coding-standards/?coding-standards/chapters/xml.md

If the XML code standard is not followed, perhaps it should be reviewed.

avatar andrepereiradasilva andrepereiradasilva - change - 27 Dec 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-12-27 23:40:44
Closed_By andrepereiradasilva
avatar andrepereiradasilva andrepereiradasilva - close - 27 Dec 2015
avatar andrepereiradasilva andrepereiradasilva - close - 27 Dec 2015
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 30 Dec 2015

Add a Comment

Login with GitHub to post a comment