? Success

User tests: Successful: Unsuccessful:

avatar bertmert
bertmert
27 Dec 2015

Cosmetic.

  • Corrected tabs.
  • All language placeholders (label, description) to uppercase.

Test after applying:

  • Create or open menu item of type List all categories
  • Check that all labels, tooltips, descriptions are still correct.
avatar bertmert bertmert - open - 27 Dec 2015
avatar bertmert bertmert - change - 27 Dec 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Dec 2015
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 27 Dec 2015
avatar sovainfo
sovainfo - comment - 27 Dec 2015

Prefer the way the name and type attributes are now. That is much more convenient when searching for a type, it reports the name of the field in the search results. When done as mentioned in the standard you'll miss out on that relevant information.

Wouldn't mind the order of label and description to be consistent.

avatar andrepereiradasilva
andrepereiradasilva - comment - 27 Dec 2015

I don't really know who made the standards, maybe suggest to them.

Made one PoC with (my interpretation of) the XML coding standards https://github.com/andrepereiradasilva/joomla-cms/blob/xml-coding-standard/components/com_wrapper/views/wrapper/tmpl/default.xml

avatar sovainfo
sovainfo - comment - 27 Dec 2015

No thank you, too far away from the format I would like to have. In general consider it far too verbose.
Consider writing a formatter according to my idea's a much better spending of my time.

avatar bertmert
bertmert - comment - 27 Dec 2015

That is much more convenient when searching for a type, it reports the name of the field in the search results.

double +1

@andrepereiradasilva
Feel free to take over this PR. For me it's done.
(Not any standardisation is a good one. Especially when it's just a waste of time and there aren't any good arguments to follow them concerning these details.)

avatar andrepereiradasilva
andrepereiradasilva - comment - 27 Dec 2015

@bertmert no, of course not, it's your PR, It was just a suggestion.

avatar brianteeman brianteeman - change - 28 Mar 2016
Category Code style Components
avatar bertmert bertmert - change - 1 Jun 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-06-01 02:28:25
Closed_By bertmert
avatar bertmert bertmert - close - 1 Jun 2016

Add a Comment

Login with GitHub to post a comment