[#8794] - Move external domains links and references to HTTPS (where possible)
- Closed
- 12 Mar 2016
- Medium
- Build: staging
- # 8794
- Diff
- andrepereiradasilva:external-https
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Description
In the last years many of the websites are moving from HTTP to HTTPS, many of those work now exclusively in HTTPS.
This PR updates the links and references through the Joomla code from HTTP to HTTPS of the following domains (and their subdomains):
- wikipedia.org (works exclusively HTTPS)
- wikimedia.org (works exclusively HTTPS)
- scribd.com (works exclusively HTTPS)
- facebook.com (works exclusively HTTPS)
- youtube.com (works exclusively HTTPS)
- google.com (works exclusively HTTPS)
- twitter.com (works exclusively HTTPS)
- github.com (works exclusively HTTPS)
- ietf.org
- schema.org
Please note that an effort has been made to not touch external vendor code.
How to test
Check the "Files changed" in this PR and verify the changes.
More info
For checking reference and links in Joomla code with HTTP has used the egrep linux command: egrep -R 'http:' /path/to/joomla/.
Suggestions or corrections are welcome.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Labels |
Added:
?
?
|
||
@andrepereiradasilva can you split this into separate PR - one for language files, one for sample data and another one for php files. Its going to be easier to get it tested and merged that way
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8794.
well i can do that after 3.5.0 release but only if it's tested and merged in a few days.
I say this because there are a lot of files, and we get conflicts very fast which means that i have to redo over and over again.
That's why I am asking you to split it up. I can accept the language files
quickly. Right now it's so big no one will look :(
And do the same for #8791 or even combine them please
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8794.
ok .will combine the two and them split: one for languages ini, other for sample data, other for php files.
Perfect - thanks
On 12 March 2016 at 14:37, andrepereiradasilva notifications@github.com
wrote:
ok .will combine the two and them split: one for languages ini, other for
sample data, other for php files.—
Reply to this email directly or view it on GitHub
#8794 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@brianteeman but we are now in language frezze so that change can only be applied in 3.5.1
yes but if you do it now. then we can merge as soon as 3.5 is released and
we wont have any conflicts
On 12 March 2016 at 15:00, andrepereiradasilva notifications@github.com
wrote:
@brianteeman https://github.com/brianteeman but we are now in language
frezze so that change can only be applied in 3.5.1—
Reply to this email directly or view it on GitHub
#8794 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
closed as comments above, new PR will be made.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-12 16:30:11 |
| Closed_By | ⇒ | andrepereiradasilva |
| Labels |
Added:
?
|
||
yes, of course, working on it