@andrepereiradasilva regarding cdn see first post of joomla/joomla-websites#20

For help.joomla.org the help screen proxy (/proxy on that subdomain)
already defaults to HTTPS and the rest of the site is effectively offline
but the htaccess should be forcing HTTPS on the landing page last I
remember. So that's fine to change any leftover links. Though those links
should probably change to something suitable in the docs wiki.

On Saturday, December 26, 2015, andrepereiradasilva <
notifications@github.com> wrote:

Description

An year after #5478 #5478,
this PR is for normalize the joomla.org URI in Joomla code to use https.

In this PR all joomla.org domains (and subdomains) in joomla code were
checked, and then checked if those serve in HTTP, HTTP and HTTPD or
exclusively HTTPS (HTTP redirect to HTTPS).

For the ones that the change seems possible without issues (certificate
errors, protocols errors, redirects to HTTP, mixed content, etc) the change
is done in this PR.

Please note this is not a blind search -> replace.
List of joomla.org domains Domain Protocols Observations All URI in HTTPS?
joomla.org HTTP and HTTPS Both redirect to www.joomla.org image:
www.joomla.org HTTP and HTTPS HTTP
redirect to HTTPS image:
docs.joomla.org HTTP and HTTPS HTTP redirect to HTTPS image:
developer.joomla.org HTTP and HTTPS HTTP
redirect to HTTPS image:
volunteers.joomla.org HTTP and HTTPS HTTP redirect to HTTPS image:
issues.joomla.org HTTP and HTTPS HTTP
redirect to HTTPS image:
api.joomla.org HTTP and HTTPS HTTP redirect to HTTPS [image:
] demo.joomla.org HTTP and HTTPS HTTP redirect to HTTPS [image:
] contribute.joomla.org HTTP and HTTPS Both redirect to
opensourcematters.org image:
update.joomla.org HTTP and HTTPS - PR related to this: #8645
#8645 help.joomla.org HTTP and
HTTPS - Code not ready yet? Same as above? shop.joomla.org HTTP and HTTPS HTTPS
has Mixed content. PR related to this: #8653
#8653 community.joomla.org HTTP
and HTTPS HTTPS has Mixed content. Site not ready yet.
resources.joomla.org HTTP and HTTPS HTTPS has Mixed content. Site not
ready yet. extensions.joomla.org HTTP and HTTPS HTTPS redirect to HTTP Site
not ready yet. forum.joomla.org HTTP and HTTPS HTTPS has protocol error. Site
not ready yet. feeds.joomla.org HTTP Feedburner Not ready yet.
build.joomla.org HTTP and HTTPS Jenkings. Certificate error Not ready yet. Other
domain in code

There are other domains used only for Unit tests to simulate errors but
doesn't really exist or are only used in unit tests, so those were not
changed:

• cdn.joomla.org
• base.joomla.org
• test.joomla.org
• xommunity.joomla.org

How to test

Check the "Files changed" in this PR and verify the changes.
More info

For checking the domains that exist in Joomla code it was used several
egrep linux commands:

• egrep -R 'joomla.org' /path/to/joomla/
• egrep -R 'http:(//|\/\/)subdomain.joomla.org' /path/to/joomla/
• egrep -R 'https:(//|\/\/)subdomain.joomla.org' /path/to/joomla/
• and other combinations

Suggestions or corrections are welcome.

You can view, comment on, or merge this pull request online at:

#8791
Commit Summary

• Merge remote-tracking branch 'refs/remotes/joomla/staging' into staging
• Merge remote-tracking branch 'refs/remotes/joomla/staging' into staging
• Merge remote-tracking branch 'refs/remotes/joomla/staging' into staging
• Merge branch 'staging' of https://github.com/andrepereiradasilva/joomla-cms into staging
• Merge remote-tracking branch 'refs/remotes/joomla/staging' into more-https-links
• From http to https

File Changes

• M README.md https://github.com/joomla/joomla-cms/pull/8791/files#diff-0 (2)
• M README.txt https://github.com/joomla/joomla-cms/pull/8791/files#diff-1 (2)
• M installation/sql/mysql/sample_learn.sql https://github.com/joomla/joomla-cms/pull/8791/files#diff-2 (6)
• M installation/sql/mysql/sample_testing.sql https://github.com/joomla/joomla-cms/pull/8791/files#diff-3 (10)
• M installation/sql/postgresql/sample_data.sql https://github.com/joomla/joomla-cms/pull/8791/files#diff-4 (2)
• M installation/sql/postgresql/sample_learn.sql https://github.com/joomla/joomla-cms/pull/8791/files#diff-5 (6)
• M installation/sql/postgresql/sample_testing.sql https://github.com/joomla/joomla-cms/pull/8791/files#diff-6 (10)
• M installation/sql/sqlazure/sample_data.sql https://github.com/joomla/joomla-cms/pull/8791/files#diff-7 (2)
• M installation/sql/sqlazure/sample_learn.sql https://github.com/joomla/joomla-cms/pull/8791/files#diff-8 (6)
• M installation/sql/sqlazure/sample_testing.sql https://github.com/joomla/joomla-cms/pull/8791/files#diff-9 (18)
• M libraries/cms/version/version.php https://github.com/joomla/joomla-cms/pull/8791/files#diff-10 (2)
• M libraries/joomla/cache/storage/file.php https://github.com/joomla/joomla-cms/pull/8791/files#diff-11 (2)
• M libraries/joomla/document/feed/renderer/atom.php https://github.com/joomla/joomla-cms/pull/8791/files#diff-12 (2)
• M tests/system/webdriver/Pages/System/AdminPage.php https://github.com/joomla/joomla-cms/pull/8791/files#diff-13 (4)
• M tests/system/webdriver/tests/report/index.php https://github.com/joomla/joomla-cms/pull/8791/files#diff-14 (2)
• M tests/unit/stubs/database/jos_banners.csv https://github.com/joomla/joomla-cms/pull/8791/files#diff-15 (2)
• M tests/unit/stubs/database/jos_content.csv https://github.com/joomla/joomla-cms/pull/8791/files#diff-16 (2)
• M tests/unit/stubs/database/jos_finder_links.csv https://github.com/joomla/joomla-cms/pull/8791/files#diff-17 (2)
• M tests/unit/stubs/database/jos_menu.csv https://github.com/joomla/joomla-cms/pull/8791/files#diff-18 (2)
• M tests/unit/stubs/database/jos_ucm_content.csv https://github.com/joomla/joomla-cms/pull/8791/files#diff-19 (2)
• M tests/unit/suites/libraries/joomla/document/JDocumentTest.php https://github.com/joomla/joomla-cms/pull/8791/files#diff-20 (4)
• M tests/unit/suites/libraries/joomla/document/feed/renderer/JDocumentRendererAtomTest.php https://github.com/joomla/joomla-cms/pull/8791/files#diff-21 (2)
• M tests/unit/suites/libraries/joomla/document/html/JDocumentHTMLTest.php https://github.com/joomla/joomla-cms/pull/8791/files#diff-22 (2)

Patch Links:

• https://github.com/joomla/joomla-cms/pull/8791.patch
• https://github.com/joomla/joomla-cms/pull/8791.diff

—
Reply to this email directly or view it on GitHub
#8791.

@mbabker
The ones that are left from help.joomla.org domain in joomla code are:

• https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/help/help.php#L187
• https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_config/controller/application/refreshhelp.php#L41
• https://github.com/joomla/joomla-cms/blob/staging/tests/unit/suites/libraries/cms/help/JHelpTest.php#L118

I think those can also be changed to HTTPS without issues. Do you agree?

Yes those can change.

On Saturday, December 26, 2015, andrepereiradasilva <
notifications@github.com> wrote:

@mbabker https://github.com/mbabker
The ones that are left from help.joomla.org domain in joomla code are:

-
https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/help/help.php#L187
-
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_config/controller/application/refreshhelp.php#L41
-
https://github.com/joomla/joomla-cms/blob/staging/tests/unit/suites/libraries/cms/help/JHelpTest.php#L118

I think those can also be changed to HTTPS without issues. Do you agree?

—
Reply to this email directly or view it on GitHub
#8791 (comment).

As for the test case involving cdn.joomla.org it's validating a behavior in that class' API and not reliant on a "real" page. You can try changing it to HTTPS but I think the protocol is dependent on the injected config values in that test case IIRC so it might end up failing without additional changes.

@mbabker thanks for your comments

Made the two changes and travis accepted them without problems.

We also have the joom.la domain (only in https://github.com/joomla/joomla-cms/blob/staging/tests/unit/suites/libraries/joomla/application/JApplicationWebTest.php) that i think is some kind of URI shortener service, right?

By the way, the certificate is incorrect in that domain.

Looking at this patch and specially the tests/unit/stubs/database/...
I found 27 occurences of these unknown characters

�*�

It's some kind of quirk unrelated to this patch (it's actually a \u0 character according to Chrome). This screenshot is me putting an echo serialize($item);die; line in before rows are written to the table where those characters are being found.

It's PHP's behavior actually... http://php.net/manual/en/function.serialize.php

Object's private members have the class name prepended to the member name; protected members have a '*' prepended to the member name. These prepended values have null bytes on either side.

Thanks Michael.

Ok. So all fine.

closed as comments above, new PR will be made.