Feeling Lucky
?
[#8786] - Syntax errors in file /com_admin/sql/updates/mysql/3.4.0-2014-09-16.sql
- Closed
- 26 Dec 2015
- Medium
- Build: master
- # 8786
IMHO file https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/sql/updates/mysql/3.4.0-2014-09-16.sql contains MySQL syntax errors :
is
ALTER TABLE `#__redirect_links` ADD header smallint(3) NOT NULL DEFAULT 301;
ALTER TABLE `#__redirect_links` MODIFY new_url varchar(255);should be
ALTER TABLE `#__redirect_links` ADD `header` smallint(3) NOT NULL DEFAULT 301;
ALTER TABLE `#__redirect_links` MODIFY `new_url` varchar(255);related: #6333
CC: @wilsonge
| Title |
|
||||||
ggppdk
- comment
- 26 Dec 2015
These will not yield a syntax error,
only
- reserved words and
- column names with special characters (e.g. space) or UTF encodings are required to be quoted/escaped,
of course it is better to quote the column names
- furthermore i tested and it seems that the class JSchemaChangeitemMysql, can handle non-quoted column names
Real reason is:
that JSchemaChangeitemMysql cannot handle
... ADD `columnname` ...
it expects "ADD COLUMN columnname", so please update your PR to make it like:
... ADD COLUMN `columnname` ...
brianteeman
- 
Bakual
- comment
- 26 Dec 2015
Closing as we have a PR
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-12-26 12:39:24 |
| Closed_By | ⇒ | Bakual |
| Labels |
Added:
?
|
||
Sounds good to me - can you do a PR for this - see https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests
Else ping me again next week when I'll have time to do it myself (I'll try and remember but got a lot going on at the moment with holidays + family stuff)