? ? Success

User tests: Successful: Unsuccessful:

avatar 810
810
24 Dec 2015

Test instructions:

Go to the warnings view on the manage page. Instead of an info alert, its now an success alert, when there are no warnings.

Also if there are warnings, you have now an warning alert.

avatar 810 810 - open - 24 Dec 2015
avatar infograf768
infograf768 - comment - 25 Dec 2015

How can we create a Warning, to test the new message?

avatar 810
810 - comment - 28 Dec 2015

what I did,change:

administrator\components\com_installer\models\warnings.php line 113 to
if ($memory_limit > 8)

avatar 810
810 - comment - 17 Jan 2016

@joomla-cms-bot please re-run the CI

avatar mbabker
mbabker - comment - 17 Jan 2016

Current staging branch needs to be merged into the branch your PR is based on. Travis runs based on a branch, it doesn't try merging the pull request's patch into the integration branch.

avatar joomla-cms-bot joomla-cms-bot - change - 28 Feb 2016
Labels Added: ? ?
avatar 810
810 - comment - 28 Feb 2016

Branch updated.

avatar andrepereiradasilva
andrepereiradasilva - comment - 28 Feb 2016

Just a suggestion, why not, instead of hardcoded Html for the message container, use the enqueueMessage method in the view.html.php file like in other views?

For instance https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_installer/views/update/view.html.php#L67

avatar brianteeman brianteeman - change - 22 Mar 2016
Status New Pending
Labels
avatar brianteeman brianteeman - change - 22 Mar 2016
Category Templates (admin) UI/UX
avatar mikeveeckmans mikeveeckmans - test_item - 2 Apr 2016 - Tested successfully
avatar mikeveeckmans
mikeveeckmans - comment - 2 Apr 2016

I have tested this item :white_check_mark: successfully on beac6a2

TEST OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8780.

avatar brianteeman brianteeman - test_item - 2 Apr 2016 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 2 Apr 2016

I have tested this item :red_circle: unsuccessfully on beac6a2

This PR uses alert-warning but we dont have a class alert-warning in the css


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8780.

avatar joomla-cms-bot
joomla-cms-bot - comment - 2 Apr 2016

This PR has received new commits.

CC: @brianteeman, @mikeveeckmans


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8780.

avatar brianteeman
brianteeman - comment - 2 Apr 2016

When there are NO warning detected
Before the patch the class is Alert-info
After the patch the class is Alert-success

I dont see why this was changed - no action has been performed so it cant be a success ;)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8780.

avatar 810
810 - comment - 2 Apr 2016

we need to standardize the colors.

update and discover = yellow (alert) = ok
standard and database = blue (info) = ok

avatar andrepereiradasilva
andrepereiradasilva - comment - 2 Apr 2016

why not use enqueueMessage?, example:

<?php if (!count($this->messages)) : ?>
    <?php JFactory::getApplication()->enqueueMessage(JText::_('COM_INSTALLER_MSG_WARNINGS_NONE'), 'notice'); ?>
<?php else : ?>
avatar joomla-cms-bot
joomla-cms-bot - comment - 2 Apr 2016

This PR has received new commits.

CC: @brianteeman, @mikeveeckmans


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8780.

avatar andrepereiradasilva
andrepereiradasilva - comment - 2 Apr 2016

Not wanting to be picky as, as it is, it's already and improvement, but shouldn't that message be outside the template?

Maybe that check and the message should be in the view.html.php file:
https://github.com/810/joomla-cms/blob/warning/administrator/components/com_installer/views/warnings/view.html.php#L34

Other views do this, check the com_installer update view for instance
https://github.com/810/joomla-cms/blob/warning/administrator/components/com_installer/views/update/view.html.php#L65-L68

avatar brianteeman brianteeman - change - 2 Apr 2016
Category Templates (admin) UI/UX Language & Strings Templates (admin) UI/UX
avatar brianteeman brianteeman - change - 2 Apr 2016
Labels
avatar 810 810 - change - 4 Apr 2016
Labels
avatar joomla-cms-bot
joomla-cms-bot - comment - 4 Apr 2016

This PR has received new commits.

CC: @brianteeman, @mikeveeckmans


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8780.

avatar 810
810 - comment - 4 Apr 2016
avatar joomla-cms-bot
joomla-cms-bot - comment - 4 Apr 2016

This PR has received new commits.

CC: @brianteeman, @mikeveeckmans


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8780.

avatar andrepereiradasilva andrepereiradasilva - test_item - 4 Apr 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 4 Apr 2016

I have tested this item :white_check_mark: successfully on 2d36d1d

thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8780.

avatar mikeveeckmans mikeveeckmans - test_item - 5 Apr 2016 - Tested successfully
avatar mikeveeckmans
mikeveeckmans - comment - 5 Apr 2016

I have tested this item :white_check_mark: successfully on 2d36d1d

TEST OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8780.

avatar brianteeman brianteeman - change - 5 Apr 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 5 Apr 2016

RTc -thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8780.

avatar joomla-cms-bot joomla-cms-bot - change - 5 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 5 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - reference | be02c16 - 12 Apr 16
avatar rdeutz rdeutz - merge - 12 Apr 2016
avatar rdeutz rdeutz - change - 12 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-12 19:07:37
Closed_By rdeutz
avatar rdeutz rdeutz - close - 12 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment