User tests: Successful: Unsuccessful:
Test instructions:
Go to the warnings view on the manage page. Instead of an info alert, its now an success alert, when there are no warnings.
Also if there are warnings, you have now an warning alert.
what I did,change:
administrator\components\com_installer\models\warnings.php line 113 to
if ($memory_limit > 8)
@joomla-cms-bot please re-run the CI
Current staging branch needs to be merged into the branch your PR is based on. Travis runs based on a branch, it doesn't try merging the pull request's patch into the integration branch.
Labels |
Added:
?
?
|
Branch updated.
Just a suggestion, why not, instead of hardcoded Html for the message container, use the enqueueMessage
method in the view.html.php
file like in other views?
Status | New | ⇒ | Pending |
Labels |
Category | ⇒ | Templates (admin) UI/UX |
I have tested this item successfully on beac6a2
TEST OK
I have tested this item unsuccessfully on beac6a2
This PR uses alert-warning but we dont have a class alert-warning in the css
This PR has received new commits.
CC: @brianteeman, @mikeveeckmans
When there are NO warning detected
Before the patch the class is Alert-info
After the patch the class is Alert-success
I dont see why this was changed - no action has been performed so it cant be a success ;)
we need to standardize the colors.
update and discover = yellow (alert) = ok
standard and database = blue (info) = ok
why not use enqueueMessage
?, example:
<?php if (!count($this->messages)) : ?>
<?php JFactory::getApplication()->enqueueMessage(JText::_('COM_INSTALLER_MSG_WARNINGS_NONE'), 'notice'); ?>
<?php else : ?>
This PR has received new commits.
CC: @brianteeman, @mikeveeckmans
Not wanting to be picky as, as it is, it's already and improvement, but shouldn't that message be outside the template?
Maybe that check and the message should be in the view.html.php
file:
https://github.com/810/joomla-cms/blob/warning/administrator/components/com_installer/views/warnings/view.html.php#L34
Other views do this, check the com_installer
update
view for instance
https://github.com/810/joomla-cms/blob/warning/administrator/components/com_installer/views/update/view.html.php#L65-L68
Category | Templates (admin) UI/UX | ⇒ | Language & Strings Templates (admin) UI/UX |
Labels |
Labels |
This PR has received new commits.
CC: @brianteeman, @mikeveeckmans
@andrepereiradasilva updated
This PR has received new commits.
CC: @brianteeman, @mikeveeckmans
I have tested this item successfully on 2d36d1d
thanks!
I have tested this item successfully on 2d36d1d
TEST OK
Status | Pending | ⇒ | Ready to Commit |
Labels |
RTc -thanks
Labels |
Added:
?
|
Milestone |
Added: |
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-12 19:07:37 |
Closed_By | ⇒ | rdeutz |
Milestone |
Removed: |
Milestone |
Added: |
Milestone |
Added: |
Milestone |
Removed: |
Labels |
Removed:
?
|
How can we create a Warning, to test the new message?