Feeling Lucky
?
[#8743] - Media manager code sprint
- Closed
- 19 Dec 2015
- Medium
- Build: staging
- # 8743
- Diff
- jissereitsma:media-manager-code-sprint
- Failure The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Stuff
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-12-19 20:46:20 |
| Closed_By | ⇒ | yireo |
jissereitsma
- comment
- 20 Dec 2015
@dgt41 Note that this was the wrong PR. The real progress is here: https://github.com/joomla-projects/media-manager-improvement
@dgt41 Hmm, I think on the surface this does not cause issues. But why is this needed? An
$offsetand$filesNoalmost seems needed to implement pagination. However, on the filesystem, pagination will never be used - you will always make a single call to read the contents (files) of the current directory and get a complete listing of those files from whatever file adapter is being used. So to implement$offsetand$filesNo, this complete listing will need to be stripped using a splitting function with no performance benefit. Or is there another reason why these calls are needed? For instance, for the AJAX call to lazyload images / create thumbs / append other information, this would be useful.