[#8735] - Load simplepie through composer and do update
- Fixed in Code Base
- 7 May 2016
- Medium
- Build: staging
- # 8735
- Diff
- wilsonge:phpmailer-update
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Previously we appeared to refrain from updating to 1.3 because of b/c issues. However 1.3.1 appeared to solve these from wordpress' experience (https://core.trac.wordpress.org/ticket/21183#comment:16).
Loading through composer also makes things easier for future updates (if there are any - the last release was 2012).
Honestly I don't know how to test this - it's going to rely on people who previously wrote simplepie specific scripts to test as all of core now uses the internal JFeed classes.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | External Library |
| Status | Pending | ⇒ | Needs Review |
SimplePie has been updated to 1.4.
https://github.com/simplepie/simplepie/blob/master/library/SimplePie.php
Version 1.2 throws Deprecated errors (functions not made "public" in this version).
Is simplepie going to be removed from next joomla package as it is announced ?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8735.
| Labels |
Added:
?
|
||
Updated. I've kept it as 1.3.1 because I can't find any information as to what is contained in 1.4.0 anywhere - the website still lists 1.3.1 as the latest version (although obviously the github tag exists for 1.4). Until I'm convinced we arent going to hit b/c breaks i'm happier sitting on 1.3.1
But yes in J4 we will still remove simplepie
| Status | Needs Review | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-07 13:36:17 |
| Closed_By | ⇒ | roland-d |
Merged on review.
@wilsonge Rebase or close this. You're probably better off doing the latter, this ain't going anywhere anyway.