[#8730] - Chnage the String class, in PHP 7 its reserved
- Closed
- 18 Dec 2015
- Medium
- Build: staging
- # 8730
- Diff
- SysBind:php7
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Fix reserved Class name and his referances in the Joomla Framework
see ticket #8729
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
Hi Brain,
I run a PHP 7 readiness test and the Sting class is still exist and use by
two functions of the OutputFilter class, right now no one call this
function but it can use easily by mistake, why not just remove it or rename
it?
On Fri, Dec 18, 2015 at 3:01 PM, Brian Teeman notifications@github.com
wrote:
Already fixed in 3.5 Beta 1 (Staging branch).
On 18 December 2015 at 12:59, Avi notifications@github.com wrote:
Fix reserved Class name and his referances in the Joomla Framework
see ticket #8729 #8729
You can view, comment on, or merge this pull request online at:
#8730
Commit Summary
- Chnage the Sting class, in PHP 7 its reserved
File Changes
- M libraries/vendor/joomla/filter/src/OutputFilter.php https://github.com/joomla/joomla-cms/pull/8730/files#diff-0 (6)
- M libraries/vendor/joomla/string/src/Inflector.php https://github.com/joomla/joomla-cms/pull/8730/files#diff-1 (6)
- R libraries/vendor/joomla/string/src/JoomlaString.php https://github.com/joomla/joomla-cms/pull/8730/files#diff-2 (2)
Patch Links:
- https://github.com/joomla/joomla-cms/pull/8730.patch
- https://github.com/joomla/joomla-cms/pull/8730.diff
—
Reply to this email directly or view it on GitHub
#8730.Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/—
Reply to this email directly or view it on GitHub
#8730 (comment).
| Title |
|
||||||
| Title |
|
||||||
Were you running that on 3.4.6 or 3.5 beta1?
On 18 December 2015 at 13:06, Avi notifications@github.com wrote:
Hi Brain,
I run a PHP 7 readiness test and the Sting class is still exist and use by
two functions of the OutputFilter class, right now no one call this
function but it can use easily by mistake, why not just remove it or rename
it?On Fri, Dec 18, 2015 at 3:01 PM, Brian Teeman notifications@github.com
wrote:Already fixed in 3.5 Beta 1 (Staging branch).
On 18 December 2015 at 12:59, Avi notifications@github.com wrote:
Fix reserved Class name and his referances in the Joomla Framework
see ticket #8729 #8729
You can view, comment on, or merge this pull request online at:
#8730
Commit Summary
- Chnage the Sting class, in PHP 7 its reserved
File Changes
- M libraries/vendor/joomla/filter/src/OutputFilter.php https://github.com/joomla/joomla-cms/pull/8730/files#diff-0 (6)
- M libraries/vendor/joomla/string/src/Inflector.php https://github.com/joomla/joomla-cms/pull/8730/files#diff-1 (6)
- R libraries/vendor/joomla/string/src/JoomlaString.php https://github.com/joomla/joomla-cms/pull/8730/files#diff-2 (2)
Patch Links:
- https://github.com/joomla/joomla-cms/pull/8730.patch
- https://github.com/joomla/joomla-cms/pull/8730.diff
—
Reply to this email directly or view it on GitHub
#8730.Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/—
Reply to this email directly or view it on GitHub
#8730 (comment).—
Reply to this email directly or view it on GitHub
#8730 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
We don't take changes to upstream files here. FWIW this has been fixed in verison 1.1.6 of the framework - so all we should need to do is update composer dependencies and this will "fix itself"
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-12-18 13:19:23 |
| Closed_By | ⇒ | wilsonge |
On staging branch
בתאריך יום ו׳, 18 בדצמ׳ 2015, 3:19 PM מאת George Wilson <
notifications@github.com>:
—
Reply to this email directly or view it on GitHub
#8730 (comment).
Ok, I just suppose to change it and be on the safe side that no one will
use it by mistake, or maybe we need to update the framework group?
On Sat, Dec 19, 2015 at 3:40 AM, George Wilson notifications@github.com
wrote:
#8730 #8730 (you know this
class is unused by the core CMS though?). We generally use the one in
libraries/joomla/filter/output.php—
Reply to this email directly or view it on GitHub
#8730 (comment).
Hi Gorge,
Thanks for the update.
On Sun, Dec 20, 2015 at 3:10 PM, George Wilson notifications@github.com
wrote:
#8734 #8734 PR here. The
framework group already did the update. We just needed to do the composer
update—
Reply to this email directly or view it on GitHub
#8730 (comment).
Already fixed in 3.5 Beta 1 (Staging branch).
On 18 December 2015 at 12:59, Avi notifications@github.com wrote:
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/