? ? Success

User tests: Successful: Unsuccessful:

avatar JerryChr
JerryChr
16 Dec 2015

I can't find any obvious/clear reason to why this field type is textarea so can't see the issue in changing it into editor. I've also encountered more times now when I needed it to be editor type.

avatar JerryChr JerryChr - open - 16 Dec 2015
avatar JerryChr JerryChr - change - 16 Dec 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Dec 2015
Status Pending New
Labels Added: ? ?
avatar joomla-cms-bot
joomla-cms-bot - comment - 16 Dec 2015

Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks.
This is an automated message from the J!Tracker Application.

avatar brianteeman
brianteeman - comment - 16 Dec 2015

I dont see the need to change this to a wyswiyg editor. As far as I can see this is an internal note only and is never displayed on the frontend so there is no need for formatting.

avatar JerryChr
JerryChr - comment - 16 Dec 2015

@brianteeman for my needs, an example could be where a client needs to show additional images/info together with the banner image in the ouput from the module, so I would use this field to do so in an override for the module - I could do that with the textarea as well, but the client can't read/code HTML so they would not know how to edit the content. I am sure there is other ways of doing this, but this seemed to be a small change that would give a bit more usefull possibilities.

avatar phproberto
phproberto - comment - 16 Dec 2015

AFAIK description is not used anywhere (frontend or backend). It's only shown in the edit form. So this change could be a way to reuse it. We cannot add description to the current views, etc. for B/C reasons but I think changing the field type is ok.

Nowadays it's quite normal having a banner with some kind of text shown there. If this allows to use it on overrides is ok for me.

filter="JComponentHelper::filterText" :+1:

avatar infograf768
infograf768 - comment - 16 Dec 2015

Also, not sure we need the Pagebreak and ReadMore buttons

buttons="true"
            hide="readmore,pagebreak"
avatar brianteeman brianteeman - test_item - 16 Dec 2015 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 16 Dec 2015

I have tested this item :red_circle: unsuccessfully on d27f012

The wysiwyg editor is loading but so are the pagebreak and readmore buttons


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8704.

avatar infograf768
infograf768 - comment - 16 Dec 2015

@brianteeman

Looks like the issue with hide buttons is not limited to this field.
I see it also for category.

Another regression I'm afraid...
Posted here: #8712

avatar infograf768
infograf768 - comment - 17 Dec 2015

We now have a solution for the buttons

Please test and confirm https://issues.joomla.org/tracker/joomla-cms/8716

We could then confirm and RTC this one


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8704.

avatar joomla-cms-bot
joomla-cms-bot - comment - 17 Dec 2015

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8704.

avatar JerryChr
JerryChr - comment - 17 Dec 2015

@brianteeman after applying #8716 it now hides the buttons. So to test this: Apply patch #8716 and #8704

avatar brianteeman brianteeman - test_item - 17 Dec 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 17 Dec 2015

I have tested this item :white_check_mark: successfully on db88d66

After applying #8716 this works


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8704.

avatar infograf768 infograf768 - test_item - 18 Dec 2015 - Tested successfully
avatar infograf768
infograf768 - comment - 18 Dec 2015

I have tested this item :white_check_mark: successfully on db88d66


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8704.

avatar infograf768 infograf768 - change - 18 Dec 2015
Category Administration Components
avatar infograf768 infograf768 - change - 18 Dec 2015
Status New Ready to Commit
avatar infograf768
infograf768 - comment - 18 Dec 2015

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8704.

avatar joomla-cms-bot joomla-cms-bot - change - 18 Dec 2015
Labels Added: ?
avatar rdeutz rdeutz - change - 6 Jan 2016
Milestone Added:
avatar wilsonge wilsonge - change - 21 Jan 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-01-21 19:52:57
Closed_By wilsonge
avatar wilsonge wilsonge - close - 21 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - close - 21 Jan 2016
avatar wilsonge wilsonge - reference | 511a0c2 - 21 Jan 16
avatar wilsonge wilsonge - merge - 21 Jan 2016
avatar wilsonge wilsonge - close - 21 Jan 2016
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jan 2016
Labels Removed: ?
avatar wilsonge wilsonge - change - 22 Mar 2016
Milestone Added:
avatar wilsonge wilsonge - change - 22 Mar 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment