Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#8698] - Compatibility with the JURI::isInternal() hardening

? Success

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
15 Dec 2015

see: #8689 - all explained there.

avatar PhilETaylor PhilETaylor - open - 15 Dec 2015
avatar PhilETaylor PhilETaylor - change - 15 Dec 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Dec 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 30 Mar 2016
Category ⇒ Components
avatar infograf768
infograf768 - comment - 11 Apr 2016

This will work if false is taken off as base64_encode accepts only one argument.

-               $item->link->setVar('return', base64_encode(JRoute::_(ContentHelperRoute::getArticleRoute($item->slug, $item->catid, $item->language), false)));
+               $item->link->setVar('return', base64_encode(ContentHelperRoute::getArticleRoute($item->slug, $item->catid, $item->language), false));

should be

-               $item->link->setVar('return', base64_encode(JRoute::_(ContentHelperRoute::getArticleRoute($item->slug, $item->catid, $item->language), false)));
+               $item->link->setVar('return', base64_encode(ContentHelperRoute::getArticleRoute($item->slug, $item->catid, $item->language)));

Can you redo?

avatar infograf768
infograf768 - comment - 11 Apr 2016

@PhilETaylor
@mbabker
Please look into this as, for me, it would solve #9846

I worry about people having used overrides, thus why I am thinking there could be a better solution.

avatar joomdonation
joomdonation - comment - 16 Apr 2016

@infograf768 The change you suggested is correct (I think it is a typo from @PhilETaylor code). If we could not fix the issue with JUri::isInternal(), we should make this change to fix the bug.

avatar joomla-cms-bot joomla-cms-bot - close - 17 Apr 2016
avatar infograf768 infograf768 - change - 17 Apr 2016
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-04-17 18:01:36
Closed_By ⇒ infograf768
avatar infograf768
infograf768 - comment - 17 Apr 2016

Closed as typos and misses a change in Beez. Replaced by #9959

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8698.

avatar infograf768
infograf768 - comment - 17 Apr 2016

Set to "closed" on behalf of @infograf768 by The JTracker Application at issues.joomla.org/joomla-cms/8698

Add a Comment

Login with GitHub to post a comment