[#8692] - Converting /includes/framework.php to a Class & refactoring
- Closed
- 13 Apr 2016
- Medium
- Build: staging
- # 8692
- Diff
- izharaazmi:joomla-bootstrapping
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Converting /includes/framework.php from linear php file to use class structure. Simplifying the two separate files framework.php in site and administrator each, using inheritance.
Introduce constant JPATH_ADMINISTRATOR_DIR to eliminate hardcoding of the backend directory name everywhere. Not used anywhere yet, but strongly intended to.
TEST INSTRUCTION
Download Joomla with this patch. You should be able to:
- Open installation page at first launch and until installation is done.
- Remove "Installation" directory without installing, it should show error message "... not found... exiting."
- After successful installation it should not allow site / administrator navigation unless "Installation" directory is removed.
- After removal of "installation" directory it should open site and administrator as usual with no difference.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
I don't see a value in this either. It also adds additional lines of code instead of reducing the necessary code... Can we get a decision by the PLT on this?
| Status | Pending | ⇒ | Needs Review |
Set to Needs Review as requested
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8692.
| Category | ⇒ | Libraries |
I agree about not really seeing the value too. So closing
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-13 08:49:52 |
| Closed_By | ⇒ | wilsonge |
What benefit is there to having the application bootstrap within a class structure? There are indeed ways to refactor the bootstrap to be a single source versus each app (site, admin, install) have their own logic and duplicated code, but I'm not convinced a class based approach is any good.