Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#8674] - Typecast queries rather than use the magic PHP method

? Success

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
13 Dec 2015

Check banners, articles and users save correctly

avatar wilsonge wilsonge - open - 13 Dec 2015
avatar wilsonge wilsonge - change - 13 Dec 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Dec 2015
Status Pending ⇒ New
Labels Added: ? ?
avatar wilsonge wilsonge - change - 13 Dec 2015
The description was changed
Labels Removed: ?
avatar chrisdavenport
chrisdavenport - comment - 13 Dec 2015

I think you're actually type casting, not type hinting. ;-)
/end-pedant-mode

avatar wilsonge wilsonge - change - 13 Dec 2015
Title
…
Typehint queries rather than use the magic PHP method
Typecast queries rather than use the magic PHP method
avatar wilsonge
wilsonge - comment - 13 Dec 2015

You are right :P I'm tired xD

avatar photodude
photodude - comment - 15 Dec 2015

Because these are controlled by if ($includeSubcategories) or is otherwise connected to authorized subcategories; testing requires use of subcategories, not just saving. Can we get some revised testing instructions that will cover the changes?

avatar brianteeman brianteeman - change - 28 Feb 2016
Category ⇒ Code style
avatar brianteeman brianteeman - change - 9 Mar 2016
Status New ⇒ Information Required
avatar mbabker
mbabker - comment - 12 Apr 2016

There's no reason for this not being merged already. I'm hitting the button.

avatar mbabker mbabker - close - 12 Apr 2016
avatar mbabker mbabker - merge - 12 Apr 2016
avatar mbabker mbabker - reference | 6043ab9 - 12 Apr 16
avatar mbabker mbabker - merge - 12 Apr 2016
avatar mbabker mbabker - close - 12 Apr 2016
avatar mbabker mbabker - change - 12 Apr 2016
Status Information Required ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-04-12 23:15:42
Closed_By ⇒ mbabker
avatar wilsonge wilsonge - head_ref_deleted - 12 Apr 2016
avatar wilsonge wilsonge - change - 12 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment