[#8672] - Fixes #8661 (part 2). Regression: Broken ordering in com_tags
- Closed
- 6 Jan 2016
- Medium
- Build: staging
- # 8672
- Diff
- bertmert:patch-43
- Pending Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Issue #8661
To test - install latest staging with sample data
Go to tags and try to sort by ID or Title. The order should change but it doesnt.
Apply patch
Try again
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
You were too fast ;-) Fix will come.
This PR has received new commits.
CC: @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8672.
I have tested this item 
successfully on c478f9d
All good now - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8672.
@brianteeman
Did you test also column ordering? At the moment I have troubles to find an easy fix.
I dont see any problem
On 13 December 2015 at 14:21, bertmert notifications@github.com wrote:
Did you test also column ordering? At the moment I have troubles to find
an easy fix.—
Reply to this email directly or view it on GitHub
#8672 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I have tested this item successfully on c478f9d
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8672.
EDIT: Solved with last commit.
One can not order ORDERING column by headline. Easy to fix.
But then you cannot sort items by moving rows up and down.
I can not confirm that
On 13 December 2015 at 15:02, bertmert notifications@github.com wrote:
One can not order by headline. Easy to fix.
But then you cannot sort items by moving rows up and down.—
Reply to this email directly or view it on GitHub
#8672 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
This PR has received new commits.
CC: @anibalsanchez, @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8672.
I can not confirm that
It was an issue with column ORDERING that used a.ordering instead of a.lft in PHP.
And a lower- uppercase issue concerning order direction. Under some circumstances one couldn't move lines because of "ASC" versus "asc".
This PR has received new commits.
CC: @anibalsanchez, @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8672.
This PR has received new commits.
CC: @anibalsanchez, @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8672.
PR is ready for testing now. Sorry for the inconvenience caused.
This PR has received new commits.
CC: @anibalsanchez, @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8672.
I have tested this item successfully on 48bdab5
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8672.
I have tested this item successfully on 48bdab5
Perfect!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8672.
| Status | Pending | ⇒ | Ready to Commit |
RTC thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8672.
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-06 11:14:48 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this item
unsuccessfully on 30c381a
The sort is fixed but there is now an additional item at the bottom of the list "Status"
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8672.