[#8661] - Regression - ordering broken in Newsfeed and Tags
- Closed
- 13 Dec 2015
- Urgent
- Build: master
- # 8661
Since the change to combine the two ordering selects into a single select (field plus direction) the ordering is completely broken
To test - install latest staging with sample data
Go to newsfeeds and try to sort by ID Ascending or ID Descending. The order should change but it doesnt
Go to tags and try to sort by ID or Title. The order should change but it doesnt
| Title |
|
||||||
| Title |
|
||||||
Do you know which PR it was that changed this select? Was it part of the Smart Search implementation?
Not had a chance to check but I would suspect so.
The problem probably came when the ordering select was changed from two boxes (field and direction) to the combined box
I discovered it while trying to create a single select for the two remaining places where there is a double select (banner-tracks and content-languages) and couldnt work out why it wasnt working
Just had a short look (newsfeeds default.php)
1.)
<input type="hidden" name="filter_order" value="<?php echo $listOrder; ?>" />
<input type="hidden" name="filter_order_Dir" value="<?php echo $listDirn; ?>" />
must be removed from default.php.
$sortFields = $this->getSortFields();
should be removed
JavaScript block
Joomla.orderTable = function()
should be removed
All
JHtml::_('grid.sort',
must be
JHtml::_('searchtools.sort'
We had a similiar issue in com_contact some days ago.
Can you do a PR for Newsfeeds and Tags please - might be needed in other places but didnt spot any
OK.
Thanks
Personally I would prefer the two box select as I think the single box is getting confused with such many options. But that's me.
It's for sure better to be consistent and working obviously 
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-12-13 18:28:03 |
| Closed_By | ⇒ | brianteeman |
Closed as we have PR
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8661.
Updated to include tags component
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8661.