? ? Pending

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
9 Dec 2015

This PR adds a new functionality to the Contact edit form that makes it possible to create & assign a new Category on the fly. See also PR #8623.

Testing Instructions

This PR uses some code in com_categories from PR #8623.
Please install PR #8623 before testing this PR.

Before the PR

Go to Components > Contacts > [New]
Create a new Contact (Title) and select an existing Category.

contact1

After the PR

Go to Components > Contacts > [New]
Create a new Contact (Title) and click on the Category dropdown.

contact2

The Category dropdown now has an option to add a new Category name.

contact3

Don't forget to click on to select your newly created Category.
When you save the Contact, the new category will be created.

contact4

After save the new Category will be in the category list (a hyphen is added in front of it).

Votes

# of Users Experiencing Issue
0/1
Average Importance Score
2.00

avatar pe7er pe7er - open - 9 Dec 2015
avatar pe7er pe7er - change - 9 Dec 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Dec 2015
Labels Added: ?
avatar Kubik-Rubik Kubik-Rubik - change - 10 Dec 2015
Labels Added: ?
avatar Kubik-Rubik Kubik-Rubik - change - 10 Dec 2015
Milestone Added:
avatar Kubik-Rubik Kubik-Rubik - change - 10 Dec 2015
Milestone Added:
avatar Kubik-Rubik Kubik-Rubik - change - 10 Dec 2015
Milestone Removed:
avatar kleinhelmi kleinhelmi - test_item - 14 Dec 2015 - Tested successfully
avatar kleinhelmi
kleinhelmi - comment - 14 Dec 2015

I have tested this item :white_check_mark: successfully on c3997c0

tested on Apache/2.4.10 (Win32) OpenSSL/1.0.1i PHP/5.5.15


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8634.

avatar anibalsanchez anibalsanchez - test_item - 19 Dec 2015 - Tested unsuccessfully
avatar anibalsanchez
anibalsanchez - comment - 19 Dec 2015

I have tested this item :red_circle: unsuccessfully on c3997c0

I tested in the latest stating, but it does now allow to click on "Add new Category 'test'"


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8634.

avatar brianteeman brianteeman - test_item - 10 Mar 2016 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 10 Mar 2016

I have tested this item :red_circle: unsuccessfully on c3997c0


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8634.

avatar brianteeman brianteeman - change - 10 Mar 2016
Category Components
avatar brianteeman
brianteeman - comment - 10 Mar 2016

@pe7er my test above was with 3.5rc - I just tested one of the other already RTC pr for this add category feature and that didnt work either so maybe its an issue since 3.5 that it doesnt work


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8634.

avatar MATsxm MATsxm - test_item - 10 Mar 2016 - Tested unsuccessfully
avatar MATsxm
MATsxm - comment - 10 Mar 2016

I have tested this item :red_circle: unsuccessfully on c3997c0

unsuccessful on 3.5rc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8634.

avatar pe7er
pe7er - comment - 11 Mar 2016

Thank you all for testing!

I've to get back to the drawing board to check why it fails,
or I might redo this PR on J3.5 Stable when it has been released.
Thanks!

avatar brianteeman
brianteeman - comment - 11 Mar 2016

@pe7er I will remove the RTC status on all of them for now with a note
saying you are reviewing them

On 11 March 2016 at 09:50, Peter Martin notifications@github.com wrote:

Thank you all for testing!

I've to get back to the drawing board to check why it fails,
or I might redo this PR on J3.5 Stable when it has been released.
Thanks!


Reply to this email directly or view it on GitHub
#8634 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 11 Mar 2016

Ah - I just spotted you had to have #8623 applied first - I completely
missed that- let me retest

On 11 March 2016 at 10:02, Brian Teeman brian@teeman.net wrote:

@pe7er I will remove the RTC status on all of them for now with a note
saying you are reviewing them

On 11 March 2016 at 09:50, Peter Martin notifications@github.com wrote:

Thank you all for testing!

I've to get back to the drawing board to check why it fails,
or I might redo this PR on J3.5 Stable when it has been released.
Thanks!


Reply to this email directly or view it on GitHub
#8634 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman brianteeman - test_item - 11 Mar 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 11 Mar 2016

I have tested this item :white_check_mark: successfully on c3997c0


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8634.

avatar brianteeman
brianteeman - comment - 11 Mar 2016

Yeah - it was me being an idiot and not applying the other PR first

@anibalsanchez @MATsxm can you please retest and make sure that you apply #8623 first


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8634.

avatar MATsxm MATsxm - test_item - 11 Mar 2016 - Tested unsuccessfully
avatar MATsxm
MATsxm - comment - 11 Mar 2016

I have tested this item :red_circle: unsuccessfully on c3997c0

I had already apply #8623 yesterday and was unsuccessful.

Try it again today (3.5rc) applying #8623 then applying #8634 and no way for me to create "Some New Category" :(

Sorry but still unsuccessful to me


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8634.

avatar mikeveeckmans mikeveeckmans - test_item - 30 Mar 2016 - Tested successfully
avatar mikeveeckmans
mikeveeckmans - comment - 30 Mar 2016

I have tested this item :white_check_mark: successfully on c3997c0

TEST OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8634.

avatar brianteeman brianteeman - change - 31 Mar 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 31 Mar 2016

I tested again and have no issues setting RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8634.

avatar joomla-cms-bot joomla-cms-bot - change - 31 Mar 2016
Labels Added: ?
avatar wilsonge
wilsonge - comment - 9 Apr 2016

Merged with 745990f - thanks again Peter!

avatar wilsonge wilsonge - change - 9 Apr 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-04-09 14:28:55
Closed_By wilsonge
avatar wilsonge wilsonge - close - 9 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 9 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 9 Apr 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment