? ? ? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
8 Dec 2015
avatar dgt41 dgt41 - open - 8 Dec 2015
avatar dgt41 dgt41 - change - 8 Dec 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Dec 2015
Status Pending New
Labels Added: ? ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 8 Dec 2015
Status New Pending
avatar joomla-cms-bot
joomla-cms-bot - comment - 8 Dec 2015

Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks.
This is an automated message from the J!Tracker Application.

avatar dgt41
dgt41 - comment - 8 Dec 2015
avatar Kubik-Rubik
Kubik-Rubik - comment - 8 Dec 2015

Merge on code review. Thank you @dgt41!

avatar Kubik-Rubik Kubik-Rubik - reference | 7be237e - 8 Dec 15
avatar Kubik-Rubik Kubik-Rubik - merge - 8 Dec 2015
avatar Kubik-Rubik Kubik-Rubik - close - 8 Dec 2015
avatar Kubik-Rubik Kubik-Rubik - change - 8 Dec 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-12-08 18:05:54
Closed_By Kubik-Rubik
avatar mbabker
mbabker - comment - 8 Dec 2015

If I'm following that correctly, then the env vars should be INSTALL_APCU for PHP 5.5/5.6 and INSTALL_APCU_BC for PHP 7 and the command for that install changed to pecl install apcu_bc-beta.

All this pull request did was rename env vars and missed changing the if conditional for the APCu beta install which makes the PHP 7 build bypass installing it giving the appearance of a passing build.

avatar dgt41
dgt41 - comment - 8 Dec 2015

Yep my bad, fixing it now

avatar dgt41 dgt41 - head_ref_deleted - 8 Jan 2016

Add a Comment

Login with GitHub to post a comment