? Error

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
8 Dec 2015

This PR corrects 2 issues concerning Single Contact display in Protostar.

Create a contact and link it to a user who has created some articles. Fill all fields. Make sure parameters are set to display all fields. Also Enable User - Profile plugin and fill fields for that user.
Create a Single contact menu item and make sure all fields are set to display.

A. RTL display (to test change en-GB.xml to <rtl>1</rtl>). Thanks @Bakual for that part.

-----------------------------------before patch

before_rtl

-----------------------------------After patch

after_rtl

B. Long article title issue. Screenshots in RTL but it is same in LTR.

-----------------------------------------before patch

before_longname

-------------------------------------------After patch

after_longname

avatar infograf768 infograf768 - open - 8 Dec 2015
avatar infograf768 infograf768 - change - 8 Dec 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Dec 2015
Labels Added: ?
avatar infograf768 infograf768 - change - 8 Dec 2015
Category Components Front End RTL
avatar infograf768 infograf768 - change - 8 Dec 2015
Easy No Yes
avatar fontanil
fontanil - comment - 8 Dec 2015

There is a problem with this patch: if title is a real title (words AND spaces), before patch it's OK, but after patch line break cuts inside words.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8612.

avatar fontanil
fontanil - comment - 8 Dec 2015

Sorry, picture uploads failed.screen shot 2015-12-08 at 07 20 42


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8612.

avatar infograf768
infograf768 - comment - 8 Dec 2015

@fontanil

I know that. What has been done here was to apply the same css used in the articles manager. That css indeed does not respect spaces anymore and cut words but, if the css is not there, then we have what I have shown above i.e. the title goes all over the page, in the articles manager too.

screen shot 2015-12-08 at 17 26 05

avatar Bakual
Bakual - comment - 8 Dec 2015

It's one thing to do that in the backend. But in frontend it looks very wrong to me to break a word.
What is the usecase for such a ridiculuous long article name without any space in it? I doubt there is even a valid case for that. And if so it happens very rarely and could be solved with custom CSS in that particular case.

avatar infograf768
infograf768 - comment - 9 Dec 2015

will create new PR for the RTL issue only...

avatar infograf768 infograf768 - change - 9 Dec 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-12-09 07:25:55
Closed_By infograf768
avatar infograf768 infograf768 - close - 9 Dec 2015
avatar infograf768 infograf768 - close - 9 Dec 2015
avatar infograf768 infograf768 - head_ref_deleted - 9 Dec 2015

Add a Comment

Login with GitHub to post a comment