? ? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
7 Dec 2015

What this PR does?

  1. Adds a new option to com_contact show_info. This option allows for the administratator to choose if they want to show the contact info. This is very useful, for instance, in cases when we only want to show a feedback form and not the contact information.

  2. Normalize show_tags option across all com_contact xml files (the option was missing in some xml).

  3. Change order of contact "show miscellaneous information" option in all xml files to appear before show articles option. This is done because show miscellaneous information it's a block of information (with tab, slider or heading, depending on the layout you choose) and not only a field like telephone, e-mail, etc. Also adds "Show " prefix to that option language variable.

How to test

  1. Use a fresh Joomla install with sample items.
  2. Create a contact with default options
  3. Create a menu item to show the contact
  4. Check the contact in the frontend. All should be fine
  5. Play with options in Global Contact Component, local options in the contact you created and in the contact option in the menu item you created and check everything is fine.
  6. Test the new show info option (by setting it to Hide) and check that the contact information doesn't appear in the frontend.

B/C

None that i think of.

More info

In future PR's i plan to normalize all com_contact XML files for better code readability, add showons, resolve some bugs and improve forms/tables accessibility.

avatar andrepereiradasilva andrepereiradasilva - open - 7 Dec 2015
avatar andrepereiradasilva andrepereiradasilva - change - 7 Dec 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Dec 2015
Labels Added: ? ?
avatar andrepereiradasilva andrepereiradasilva - change - 7 Dec 2015
Title
com_contact New option show_info (hide/show) and others
New option in com_contact show_info (hide/show) and others
avatar andrepereiradasilva andrepereiradasilva - change - 7 Dec 2015
Title
New option in com_contact show_info (hide/show) and others
New show_info option (hide/show) in com_contact and some minor changes
avatar andrepereiradasilva
andrepereiradasilva - comment - 7 Dec 2015

it seems travis is going crazy with APCU

avatar brianteeman brianteeman - change - 28 Mar 2016
Category Components
avatar brianteeman brianteeman - change - 28 Mar 2016
Labels
avatar brianteeman brianteeman - change - 27 Apr 2016
Category Components Components Language & Strings
avatar wmchris wmchris - test_item - 1 Aug 2016 - Tested successfully
avatar wmchris
wmchris - comment - 1 Aug 2016

I have tested this item successfully on ef2329b

Test worked well - contact info disappeared after changing the flag @icampus


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8607.

avatar Schmidie64
Schmidie64 - comment - 1 Aug 2016

tested @icampus:

avatar Schmidie64 Schmidie64 - test_item - 2 Aug 2016 - Tested successfully
avatar Schmidie64
Schmidie64 - comment - 2 Aug 2016

I have tested this item successfully on ef2329b

tested @icampus:
•installed plugin successfully
•followed instructions for reproduce
•everything worked well


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8607.

avatar brianteeman brianteeman - change - 2 Aug 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 2 Aug 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8607.

avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 2 Aug 2016
Labels Added: ?
avatar rdeutz
rdeutz - comment - 11 Sep 2016

@andrepereiradasilva I have changed the base for this PR to 3.7.x hope that makes solving the conflicts easier

avatar rdeutz
rdeutz - comment - 1 Oct 2016

@andrepereiradasilva could you have a look at the conflicts and resolve them, thanks!

avatar andrepereiradasilva
andrepereiradasilva - comment - 2 Oct 2016

@rdeutz conflicts fixed

avatar rdeutz rdeutz - change - 3 Oct 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-10-03 06:23:27
Closed_By rdeutz
avatar rdeutz rdeutz - close - 3 Oct 2016
avatar rdeutz rdeutz - merge - 3 Oct 2016
avatar zero-24 zero-24 - close - 3 Oct 2016
avatar zero-24 zero-24 - change - 3 Oct 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment