[#8599] - [Accessibility] Category list
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Description
This PR makes category list menu item type acessible according to WCAG 2.0.
1. List of articles table:
-
Now the table header always exists in the HTML, through CSS it show or hides according to "Show Headings" Show/Hide selection.
-
A
captiontag (css hidden by default) is added to the Table. -
Column scopes (
scope="col") are added tothtags.See http://www.w3.org/TR/WCAG20-TECHS/H63.html
- Form with filters:
- The form tag is now only in for the filter field (not form + table inside form tag like before).
-
A
legendtag (css hidden by default) is added to the fieldset. -
A submit button is added (css hidden by default) to the filter form.
See http://www.w3.org/TR/WCAG20-TECHS/H32.html
How to test
- Use a fresh joomla install with sample items.
- Create a "Category list" menu item type and play with "List layout" separator options and check if everything is showing as it should in the frontend.
- Use an external automatic acessibility checker to check if everything is ok. Some tools: http://www.w3.org/WAI/ER/tools/ #### More info
Improvements are welcome
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Title |
|
||||||
| Labels | |||
| Category | ⇒ | Accessibility |
| Labels | |||
| Category | Accessibility | ⇒ | Accessibility Language & Strings |
I have tested this item
I have tested this issue @icampus PBF with the proposed patch and have pretty much the same "issues" as Curtista. I followed your "How to test" but on a local server and inspected the site myself. Your patch definitely improves the accessibility but seems to omit the scope attribute of the first th-tag.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8599.
added missing scope
I have tested this item
Everything fine, even the scope="col" is now Present
@icampus Pizza,Bugs&Fun
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8599.
I have tested this item
Tested it like I did previously @icampus and its working perfect for me this time
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8599.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC - sorry for the delay
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8599.
| Labels |
Added:
?
|
||
@andrepereiradasilva there are merge conflicts here can you fix that?
| Milestone |
Added: |
||
any change to fix the conflicts @andrepereiradasilva ?
sorry ... to many PR. will do when i can
| Labels |
Removed:
?
|
||
| Milestone |
Removed: |
||
| Status | Ready to Commit | ⇒ | Pending |
| Labels | |||
| Milestone |
Removed: |
||
Can we have one more test here please now these conflicts have been fixed? Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8599.
| Labels | |||
hum ... i think there a potencial issue here.
if i'm not wrong if a site that uses other template does not have this hide css classes the form legend and table caption will appear in the site, the same goes for table-noheader class.
I could, force the css here for B/C in the file, @wilsonge what do you think?
ok added the css classes inline too to prevent that issue
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/8599.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/8599.
@andrepereiradasilva sorry to say that we have merge conflicts again. If you can fix them i will make sure it gets merged quickly and wont happen again
I have tested this item
Tested issue successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/8599.
I've manually fixed the conflicts here and merged it. @brianteeman could you just check i haven't screwed anything up please
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-04 12:46:53 |
| Closed_By | ⇒ | wilsonge |
| Category | Accessibility Language & Strings | ⇒ | Front End Components Language & Strings Templates (site) Accessibility |
| Labels |
Removed:
?
|
||
I have tested this item? unsuccessfully on d3070e0
First I've done the steps in the "How to Test".
For the 3th step I've used the Wave Chrome extension available at http://wave.webaim.org/ which only recognizes that (before the patch) there was no
legendtag in the fieldset.The remaining changes I had to test manually against the specifications, because I run Joomla on my local machine and found no tool except for the wave chrome extension.
Now lets talk about the changes. When I was testing it manually everything was fine except for that the first
thtag in the table had noscope="col". Because of this missingscope="col"the test was unsuccessful.@icampus
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8599.