?
avatar siliconalchemy
siliconalchemy
1 Dec 2015

The core session calls in libraries/cms/application/cms.php - loadSession(), checkSession() contains database code. Session handling shouldn't touch the database per se, only if a db storage provider is used. If 'none' or memcache/redis etc are used then database shouldn't be touched as it pretty much guarantees deadlocks and clashes, and makes Joomla unuseable on consistent db clusters.

I think this is what this PR is trying to fix?
joomla/joomla-cms#6608

Please consider fixing this, it's really important to use Joomla in HA/cluster environment.

avatar siliconalchemy siliconalchemy - open - 1 Dec 2015
avatar mbabker
mbabker - comment - 1 Dec 2015

All that PR fixes is doing the job of the session handler's gc() method. The checkSession() method needs major rewrites as well. Going a step further, joomla-projects/joomla-pythagoras#62 identifies all flaws in current session handling code and fixing most of that is probably out of scope for the 3.x series unless there are some developers left who understand session handling and can clean the mess up.

avatar brianteeman brianteeman - change - 14 Dec 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 13 Apr 2016
Category Libraries
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2016
The description was changed
avatar joomla-cms-bot joomla-cms-bot - edited - 13 Apr 2016
avatar franz-wohlkoenig franz-wohlkoenig - change - 6 Apr 2017
Status New Needs Review
avatar mbabker
mbabker - comment - 25 May 2017

#13322 makes the recording of session metadata optional in 4.0. If accepted, that would fix this, if not accepted then architecturally this is a "won't fix" item. Closing this issue in favor of the PR which would address this.

avatar mbabker mbabker - change - 25 May 2017
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2017-05-25 01:37:47
Closed_By mbabker
avatar mbabker mbabker - close - 25 May 2017

Add a Comment

Login with GitHub to post a comment