Joomla! Issue Tracker | Joomla! CMS #8574 - Fix JavaScript error in TinyMCE button plugins

Closed
30 Nov 2015
Medium
Build: 3.5-dev
# 8574
Diff
piotrmocko:patch-24

Pending

Pending The Travis CI build is in progress Details

User tests: Successful: Unsuccessful:

piotrmocko
30 Nov 2015

To test it install OneDrive extension and enable editor buttons plugins.
Go to article edit view and hit OneDrive button. Check you browser console to see the error.
https://www.perfect-web.co/joomla-extensions/microsoft-onedrive-gallery-file

When button plugin has onclick property with JavaScript code it is being added after
editor.windowManager.open({...});
So there can not be a coma (,) between above code and onclick code define in plugin.
Below is code rendered by TinyMCE plugin which contains a coma (line before SkyDriveButton...) which leads to JavaScript error

editor.addButton("OneDriveFile", {
    text: "OneDrive File",
    title: "OneDrive File",
    icon: "none icon-flag-2", 
    onclick: function () {
        editor.windowManager.open({
            title : "OneDrive File",
            url : 'http://localhost/administrator/index.php',
            buttons: [{ text : "Close", onclick: "close" }] 
        });,
        SkyDriveButton.browseFile('tinymce');
        return false;
    }
});

32e2fd0 30 Nov 2015

Fix JavaScript error

piotrmocko - open - 30 Nov 2015

piotrmocko - change - 30 Nov 2015

Status

New

⇒

Pending