? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
28 Nov 2015

Description

Language change to 'None' Session handler that is not correct. Is not None, is PHP session handler.

How to test

Go to System -> Global configurarion, System separator, Session Settings block.
In 'Session handler' should be at least 'Database' and 'PHP'. Check tooltip too.

avatar andrepereiradasilva andrepereiradasilva - open - 28 Nov 2015
avatar andrepereiradasilva andrepereiradasilva - change - 28 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Nov 2015
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 29 Nov 2015

When modifying en-GB.lib_joomla.ini, both site file and admin file should be modified.

avatar NLRoosj
NLRoosj - comment - 13 Dec 2015

Hi, I'm not able to reproduce this, but I'm not sure if I understand the issue: changing language, and then the session handler changes to 'None' instead of 'Database'? Switched languages to Dutch and German.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8565.

avatar andrepereiradasilva
andrepereiradasilva - comment - 13 Dec 2015

@NLRoosj

The issue here is that in Joomla by default you have 2 session manager options:

Some examples of session handler and save path in PHP:

; FILES
session.save_handler = files
session.save_path = /tmp

; REDIS
session.save_handler = redis
session.save_path = "tcp://_REDIS-HOST_:6379"

; REDIS (multiple servers with load balancing)
session.save_path = "tcp://_REDIS-HOST1_:6379?weight=1, tcp://_REDIS-HOST2_:6379?weight=2, tcp://_REDIS-HOST3_:6379?weight=2"

; MEMCACHE
session.save_handler = memcache 
session.save_path = "tcp://_MEMCACHE-HOST_:11211" 

; MEMCACHED
session.save_handler = memcached 
session.save_path = "_MEMCACHED-HOST_:11211" 

So this PR changes the language text from "None" to "PHP" since when we set session handler to "None" we are really setting it to "PHP" session handler.

So, it's not a code problem is a language correction.
The correction is only for en-GB language, in other languages the translators need to correct it.

avatar andrepereiradasilva andrepereiradasilva - change - 13 Dec 2015
Title
None is something
Changes Session Handler text from "None" to "PHP"
avatar brianteeman
brianteeman - comment - 13 Dec 2015

Makes sense to me - good change

On 13 December 2015 at 13:03, andrepereiradasilva notifications@github.com
wrote:

@NLRoosj https://github.com/NLRoosj

The issue here is that in Joomla by default you have 2 session manager
options:

Some examples of session handler and save path in PHP:

FILES
session.save_handler = files
session.save_path = /tmp

REDIS
session.save_handler = redis
session.save_path = "tcp://REDIS-HOST:6379?auth=REDIS-PASSWORD"

MEMCACHE
session.save_handler = memcache
session.save_path = "tcp://MEMCACHE-HOST:11211"

MEMCACHED
session.save_handler = memcached
session.save_path = "MEMCACHED-HOST:11211"

So this PR changes the language text from "None" to "PHP" since when we
set session handler to "None" we are really setting it to "PHP" session
handler.

So, it's not and issue is a language correction.
The correction is only in en-GB language, in other languages the
translators need to correct it.


Reply to this email directly or view it on GitHub
#8565 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman brianteeman - test_item - 13 Dec 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 13 Dec 2015

I have tested this item :white_check_mark: successfully on 770d23d

Makes sense


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8565.

avatar Fedik Fedik - test_item - 13 Dec 2015 - Tested successfully
avatar Fedik
Fedik - comment - 13 Dec 2015

I have tested this item :white_check_mark: successfully on 770d23d


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8565.

avatar NLRoosj NLRoosj - test_item - 13 Dec 2015 - Tested successfully
avatar NLRoosj
NLRoosj - comment - 13 Dec 2015

I have tested this item :white_check_mark: successfully on 770d23d

@andrepereiradasilva: thanks for the clarification ! It does make sense indeed; tested succesfully.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8565.

avatar brianteeman brianteeman - change - 14 Dec 2015
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 14 Dec 2015

Setting RTC - thanks for testing


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8565.

avatar joomla-cms-bot joomla-cms-bot - change - 14 Dec 2015
Labels Added: ?
avatar rdeutz rdeutz - change - 6 Jan 2016
Milestone Added:
avatar wilsonge wilsonge - close - 17 Jan 2016
avatar wilsonge wilsonge - change - 17 Jan 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-01-17 13:26:23
Closed_By wilsonge
avatar wilsonge wilsonge - change - 17 Jan 2016
Milestone Added:
avatar wilsonge wilsonge - change - 17 Jan 2016
Milestone Removed:
avatar wilsonge wilsonge - change - 17 Jan 2016
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 17 Jan 2016

Add a Comment

Login with GitHub to post a comment