User tests: Successful: Unsuccessful:
Language change to 'None' Session handler that is not correct. Is not None, is PHP session handler.
Go to System -> Global configurarion, System separator, Session Settings block.
In 'Session handler' should be at least 'Database' and 'PHP'. Check tooltip too.
Status | New | ⇒ | Pending |
Labels |
Added:
?
?
|
Hi, I'm not able to reproduce this, but I'm not sure if I understand the issue: changing language, and then the session handler changes to 'None' instead of 'Database'? Switched languages to Dutch and German.
The issue here is that in Joomla by default you have 2 session manager options:
Some examples of session handler and save path in PHP:
; FILES
session.save_handler = files
session.save_path = /tmp
; REDIS
session.save_handler = redis
session.save_path = "tcp://_REDIS-HOST_:6379"
; REDIS (multiple servers with load balancing)
session.save_path = "tcp://_REDIS-HOST1_:6379?weight=1, tcp://_REDIS-HOST2_:6379?weight=2, tcp://_REDIS-HOST3_:6379?weight=2"
; MEMCACHE
session.save_handler = memcache
session.save_path = "tcp://_MEMCACHE-HOST_:11211"
; MEMCACHED
session.save_handler = memcached
session.save_path = "_MEMCACHED-HOST_:11211"
So this PR changes the language text from "None" to "PHP" since when we set session handler to "None" we are really setting it to "PHP" session handler.
So, it's not a code problem is a language correction.
The correction is only for en-GB language, in other languages the translators need to correct it.
Title |
|
Makes sense to me - good change
On 13 December 2015 at 13:03, andrepereiradasilva notifications@github.com
wrote:
@NLRoosj https://github.com/NLRoosj
The issue here is that in Joomla by default you have 2 session manager
options:
- "Database": Uses the database to manage session
- "None": Uses php.ini configured session handler (this can be file, database, redis, memcache, etc). Check: http://php.net/manual/en/session.configuration.php#ini.session.save-handler and http://php.net/manual/en/session.configuration.php#ini.session.save-path
Some examples of session handler and save path in PHP:
FILES
session.save_handler = files
session.save_path = /tmpREDIS
session.save_handler = redis
session.save_path = "tcp://REDIS-HOST:6379?auth=REDIS-PASSWORD"MEMCACHE
session.save_handler = memcache
session.save_path = "tcp://MEMCACHE-HOST:11211"MEMCACHED
session.save_handler = memcached
session.save_path = "MEMCACHED-HOST:11211"So this PR changes the language text from "None" to "PHP" since when we
set session handler to "None" we are really setting it to "PHP" session
handler.So, it's not and issue is a language correction.
The correction is only in en-GB language, in other languages the
translators need to correct it.—
Reply to this email directly or view it on GitHub
#8565 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I have tested this item successfully on 770d23d
Makes sense
I have tested this item successfully on 770d23d
I have tested this item successfully on 770d23d
@andrepereiradasilva: thanks for the clarification ! It does make sense indeed; tested succesfully.
Status | Pending | ⇒ | Ready to Commit |
Labels |
Setting RTC - thanks for testing
Labels |
Added:
?
|
Milestone |
Added: |
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-17 13:26:23 |
Closed_By | ⇒ | wilsonge |
Milestone |
Added: |
Milestone |
Removed: |
Labels |
Removed:
?
|
When modifying en-GB.lib_joomla.ini, both site file and admin file should be modified.