? ? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
28 Nov 2015

Error in #8140

We get
screen shot 2015-11-27 at 17 43 51

After this Pr we will rightfully get

screen shot 2015-11-28 at 08 13 12

I have also modified the constant (as it is a new string, it is OK. Thanks Mig for that one)

-COM_FINDER_MAPS_SELECT_BRANCHE="- Select Branch -"
+COM_FINDER_MAPS_SELECT_BRANCH="- Select Branch -"

and corrected the spaces to tabs in filter_maps.xml

avatar infograf768 infograf768 - open - 28 Nov 2015
avatar infograf768 infograf768 - change - 28 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Nov 2015
Labels Added: ? ?
avatar infograf768 infograf768 - change - 28 Nov 2015
Category Administration Components Language & Strings
avatar fontanil fontanil - test_item - 28 Nov 2015 - Tested successfully
avatar fontanil
fontanil - comment - 28 Nov 2015

I have tested this item :white_check_mark: successfully on dbc02cb

Tested with success on last staging. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8558.

avatar brianteeman
brianteeman - comment - 28 Nov 2015

Good spot that it should have a -select- string BUT I am not sure it is correct
Shouldnt it be - Select Content Map - that is the menu name

and the string Branches Only doesnt seem to make sense to me as it is actually All Branches or All Content Maps as its a parent item containing all the other content maps/branches.

If thats correct then the string Return to Branches should also probably be changed to Return to Content Maps

avatar infograf768
infograf768 - comment - 28 Nov 2015

Branches only as well as Return to branches exist in core since the original porting of com_finder to Joomla.

See history (2011), where the terms branches and content maps are already present:
https://github.com/joomla/joomla-cms/blob/baa509338c8b92e41999fbc8d79ac755f9b6a761/administrator/language/en-GB/en-GB.com_finder.ini

We also have:
COM_FINDER_STATISTICS_STATS_DESCRIPTION="The indexed content on this site includes %s terms across %s links with %s attributes in %s branches."
COM_FINDER_MAPS_BRANCH_LINK="Select to show the children in this branch."
COM_FINDER_MAPS_MULTILANG="Note: Language filter system plugin has been enabled, so this branch will not be used."

We can obviously change whatever needed, but this patch is only correcting an error in #8140 where the Select should have been on top of dropdown and get rid of "Branches only" which never made any sense.

avatar infograf768
infograf768 - comment - 28 Nov 2015

Looking further into this: there is a difference between Branches and Maps
A branch is a sort of category which contains maps (also called children)
I.e. when you display only one branch, its contents are maps, which you can publish/unpublish/delete if desired.

screen shot 2015-11-28 at 11 46 31

Therefore I would leave the terms alone and just merge this PR correcting #8140

avatar brianteeman brianteeman - test_item - 28 Nov 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 28 Nov 2015

I have tested this item :white_check_mark: successfully on dbc02cb

String changed correctly


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8558.

avatar brianteeman
brianteeman - comment - 28 Nov 2015

OK I guess any other change is out of scope so its a good test from me


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8558.

avatar infograf768 infograf768 - change - 28 Nov 2015
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 28 Nov 2015

2 good tests. RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8558.

avatar joomla-cms-bot joomla-cms-bot - change - 28 Nov 2015
Labels Added: ?
avatar rdeutz rdeutz - change - 29 Nov 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-11-29 08:41:38
Closed_By rdeutz
avatar wilsonge wilsonge - change - 17 Jan 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment