Language Change PR-staging

Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
27 Nov 2015

Version 4.3

See the changes here:
http://blog.tinymce.com/2015/11/24/tinymce-4-3-brings-new-features-stability-improvements/

And the changeling here:
https://github.com/tinymce/tinymce/blob/master/changelog.txt

Testing

D/L https://github.com/dgt41/joomla-cms/archive/tinyMCE43.zip
Install joomla as usual and test that tinyMCE didn't introduce any bug

avatar dgt41 dgt41 - open - 27 Nov 2015
avatar dgt41 dgt41 - change - 27 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Nov 2015
Labels Added: Language Change PR-staging
avatar joomla-cms-bot joomla-cms-bot - change - 27 Nov 2015
Labels Added: Language Change PR-staging
avatar infograf768
infograf768 - comment - 27 Nov 2015

version change needed in the xml

avatar dgt41
dgt41 - comment - 27 Nov 2015

New lang string "Source code"

avatar infograf768
infograf768 - comment - 27 Nov 2015

New lang string "Source code"

OK, I guess this is not anyway for 3.5.0, right?

avatar dgt41
dgt41 - comment - 27 Nov 2015

@infograf768 I guess I need to bring support for codesample here as well, but it looks very nice:
screen shot 2015-11-27 at 18 36 06

avatar Gerlof Gerlof - test_item - 29 Nov 2015 - Tested successfully
avatar Gerlof
Gerlof - comment - 29 Nov 2015

I have tested this item :white_check_mark: successfully on a995871


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8553.

avatar anibalsanchez
anibalsanchez - comment - 2 Dec 2015

Tried to install in 5.6.14... but I am getting error 500 in the final installation steps:

http://..../joomla-cms-tinyMCE43/installation/index.php?task=InstallConfig - 500 Internal Server Error

It may not be even related with the new editor


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8553.

avatar anibalsanchez anibalsanchez - test_item - 5 Dec 2015 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 5 Dec 2015

I have tested this item :white_check_mark: successfully on a995871

Test OK, on the latest staging with diff file


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8553.

avatar brianteeman brianteeman - change - 12 Dec 2015
Category External Library
avatar brianteeman brianteeman - change - 12 Dec 2015
Labels
avatar mikeh000
mikeh000 - comment - 15 Jan 2016

So is this coming to Joomla 3.5?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8553.

avatar brianteeman brianteeman - change - 15 Jan 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 15 Jan 2016

RTC - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8553.

avatar joomla-cms-bot joomla-cms-bot - change - 15 Jan 2016
Labels Added: RTC
avatar dgt41
dgt41 - comment - 15 Jan 2016

@mikeh000 unfortunately 3.5 is in Beta phase which means new features could not be introduced, so this has to wait till 3.5.1.

avatar brianteeman
brianteeman - comment - 15 Jan 2016

How is updating a library a new feature

avatar wilsonge
wilsonge - comment - 15 Jan 2016

No I will merge this for 3.5.0 if this has the tests and the conflicts get merged. Just get that thing updated.

avatar joomla-cms-bot
joomla-cms-bot - comment - 15 Jan 2016

This PR has received new commits.

CC: @anibalsanchez, @Gerlof


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8553.

avatar dgt41
dgt41 - comment - 15 Jan 2016

Ok synchronised!
@wilsonge Version 4.3.3 (2016-01-14) was released yesterday, shall I update this to 4.3.3?

avatar anibalsanchez anibalsanchez - test_item - 15 Jan 2016 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 15 Jan 2016

I have tested this item :white_check_mark: successfully on dbb6124

Still, it works OK :-D


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8553.

avatar joomla-cms-bot
joomla-cms-bot - comment - 16 Jan 2016

This PR has received new commits.

CC: @anibalsanchez, @Gerlof


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8553.

dbe6ef9 16 Jan 2016 avatar dgt41 4.3.3
avatar joomla-cms-bot
joomla-cms-bot - comment - 16 Jan 2016

This PR has received new commits.

CC: @anibalsanchez, @Gerlof


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8553.

avatar anibalsanchez anibalsanchez - test_item - 16 Jan 2016 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 16 Jan 2016

I have tested this item :white_check_mark: successfully on dbe6ef9

And, Still, it works OK :-D


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8553.

avatar infograf768
infograf768 - comment - 16 Jan 2016

@joomla/cms-maintainers
When this is merged, let TTs know about the new TinyMCE lang string (not the ini file).

@dgt41
<creationDate>2005-2015</creationDate> => 2016

avatar wilsonge wilsonge - change - 17 Jan 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-01-17 13:13:01
Closed_By wilsonge
avatar wilsonge wilsonge - reference | 06e15ad - 17 Jan 16
avatar wilsonge wilsonge - merge - 17 Jan 2016
avatar wilsonge wilsonge - close - 17 Jan 2016
avatar wilsonge
wilsonge - comment - 17 Jan 2016

Thanks @dgt41 :)

avatar joomla-cms-bot joomla-cms-bot - change - 17 Jan 2016
Labels Removed: RTC
avatar wilsonge wilsonge - change - 17 Jan 2016
Milestone Added: Joomla! 3.5.0
avatar wilsonge wilsonge - reference | 1fcea3b - 17 Jan 16
avatar dgt41 dgt41 - head_ref_deleted - 17 Jan 2016
avatar infograf768
infograf768 - comment - 18 Jan 2016

The new lang string is
"Insert\/Edit code sample":

avatar mikeh000
mikeh000 - comment - 21 Jan 2016

Can it be version 4.3.3 that gets merged to Joomla 3.5?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8553.

avatar infograf768
infograf768 - comment - 21 Jan 2016

it is 4.3.3 which has been merged.

avatar wilsonge wilsonge - change - 21 Jan 2016
Title
Update tinyMCE to version 4.3
Update tinyMCE to version 4.3.3

Add a Comment

Login with GitHub to post a comment