? ? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
27 Nov 2015

A question was raised during some training regarding the menu module and assigning links to a menu - what is a menu location? It really makes no sense to call a menu a menu location in this case.

Before

staging administration menus new item

After

yzst

Before

ig0o

After

aozw

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar brianteeman brianteeman - open - 27 Nov 2015
avatar brianteeman brianteeman - change - 27 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Nov 2015
Labels Added: ? ?
avatar zero-24 zero-24 - change - 27 Nov 2015
Category Language & Strings
avatar zero-24 zero-24 - change - 27 Nov 2015
Status Pending Ready to Commit
Labels
avatar zero-24
zero-24 - comment - 27 Nov 2015

Sounds better to me.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8551.

avatar joomla-cms-bot joomla-cms-bot - change - 27 Nov 2015
Labels Added: ?
avatar infograf768
infograf768 - comment - 28 Nov 2015

OK for me.

avatar Gerlof Gerlof - test_item - 29 Nov 2015 - Tested successfully
avatar Gerlof
Gerlof - comment - 29 Nov 2015

I have tested this item :white_check_mark: successfully on 3604624


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8551.

avatar pjwiseman
pjwiseman - comment - 1 Dec 2015

I think changing from "Menu Location" to "Menu" is good. However, if we're going to include a terminology change from "menu type" to "menu", I think it should be done everywhere. Code comments included. I count 38 occurrances (31 when greping for "menu type" and "Menu Type", and 7 when grepping for "menu location" and "Menu Location".


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8551.

avatar brianteeman
brianteeman - comment - 1 Dec 2015

My opinion. The other uses of menu type are correct. This is not a change but a correction in one place

avatar pjwiseman pjwiseman - test_item - 2 Dec 2015 - Tested successfully
avatar pjwiseman
pjwiseman - comment - 2 Dec 2015

I have tested this item :white_check_mark: successfully on 3604624

@brianteeman Fair enough. Thanks for the clarification.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8551.

avatar NLRoosj NLRoosj - test_item - 12 Dec 2015 - Tested successfully
avatar NLRoosj
NLRoosj - comment - 12 Dec 2015

I have tested this item :white_check_mark: successfully on 3604624


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8551.

avatar wilsonge wilsonge - change - 13 Dec 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-12-13 22:05:43
Closed_By wilsonge
avatar wilsonge wilsonge - reference | 8e05570 - 13 Dec 15
avatar wilsonge wilsonge - merge - 13 Dec 2015
avatar wilsonge wilsonge - close - 13 Dec 2015
avatar wilsonge wilsonge - change - 13 Dec 2015
Milestone Added:
avatar brianteeman brianteeman - head_ref_deleted - 13 Dec 2015
avatar wilsonge wilsonge - change - 17 Jan 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment