? ? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
27 Nov 2015

See #8171 for the initial discussion.

The issue we have is that in Crowdin (and probably other translation tools) we can't translate strings where there is nothing to translate. So empty strings can't be translated.

This particular string here goes beyond translating as it also decides if a menuitem in the help menu is shown or not. However I don't see a reason why we can't always show the link to the language forums.

Testing

After applying this PR, you now see a new menuitem in the help menu pointing to the language forums.

avatar Bakual Bakual - open - 27 Nov 2015
avatar Bakual Bakual - change - 27 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Nov 2015
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 27 Nov 2015

As the other values in the menu are in capital case then for consistency this should be as well

MOD_MENU_HELP_SUPPORT_OFFICIAL_FORUM="Official Support Forum"
MOD_MENU_HELP_SUPPORT_CUSTOM_FORUM="Custom Support Forum"
MOD_MENU_HELP_SUPPORT_OFFICIAL_LANGUAGE_FORUM="Official language forums"

==>
MOD_MENU_HELP_SUPPORT_OFFICIAL_LANGUAGE_FORUM="Official Language Forums"

avatar Bakual
Bakual - comment - 27 Nov 2015

Done. Good point.

avatar andrepereiradasilva andrepereiradasilva - test_item - 4 Jan 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 4 Jan 2016

I have tested this item :white_check_mark: successfully on 82e71c0


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8547.

avatar wojsmol wojsmol - test_item - 18 Jan 2016 - Tested successfully
avatar wojsmol
wojsmol - comment - 18 Jan 2016

I have tested this item :white_check_mark: successfully on 82e71c0


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8547.

avatar brianteeman brianteeman - change - 20 Jan 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 20 Jan 2016

Setting RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8547.

avatar joomla-cms-bot joomla-cms-bot - change - 20 Jan 2016
Labels Added: ?
avatar wilsonge wilsonge - reference | f8ba3f0 - 26 Jan 16
avatar wilsonge wilsonge - merge - 26 Jan 2016
avatar wilsonge wilsonge - change - 26 Jan 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-01-26 23:36:15
Closed_By wilsonge
avatar wilsonge wilsonge - close - 26 Jan 2016
avatar wilsonge wilsonge - change - 26 Jan 2016
Milestone Added:
avatar Bakual Bakual - head_ref_deleted - 27 Jan 2016
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment