[#852] - Fixed alignment of admin menu icons
- Closed
- 25 Mar 2013
- Medium
- Build: master
- # 852
- Diff
- unknown repository
- Foreign ID 30347
User tests: Successful: Unsuccessful:
Tracker item: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30347
Joomla 3.1 has introduced the menu icons in the admin top nav again (for components, etc).
However, when using the standard 16x16px sized icons, the alignment is off.
This fix corrects that issue.
This fix also prevents the icon from showing up on narrow-screen (because there is no room for it and the menu item title overlaps the icon).
Testing instructions
If you don't have a component with an icon, add an icon to a component by placing the url (relative to the admin folder) of the icon in the 'img' field of the #__menu table for that component.
Now compare the menu item in the administrator menu (under Components).
Also check on narrow-screen (resize browser to less than 738px wide)
Incidentally, I didn't intend for the icons to be visible in Isis, that was supposed to only work in Hathor and be available for template designers to use if they wanted to (remember Kyle purposely left them out of Isis). If I ever get around to it, I do intend on killing the icons again, just an FYI.
Thanks for coding this, Peter!
For anyone interested, here's the tracker item on JoomlaCode:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30347
So would it be better to remove the icons altogether again from Isis? Easy css change.
I changed this pull request so it removed the icons completely from the isis admin menu.
Greatly appreciated, and sorry to be a PITA.
What about adding 1px of space to left and right to the icon?